change(tracker): remove dom drop detection on tracker side

backend/pkg/messages/messages.go

@@ -2105,15 +2105,13 @@ func (msg *MouseThrashing) TypeID() int {
 type RemovedNodesCount struct {
 	message
 	NodesCount uint64
-	DOMDropped bool
 }
 
 func (msg *RemovedNodesCount) Encode() []byte {
-	buf := make([]byte, 21)
+	buf := make([]byte, 11)
 	buf[0] = 115
 	p := 1
 	p = WriteUint(msg.NodesCount, buf, p)
-	p = WriteBoolean(msg.DOMDropped, buf, p)
 	return buf[:p]
 }
 

backend/pkg/messages/read-message.go

@@ -1275,9 +1275,6 @@ func DecodeRemovedNodesCount(reader BytesReader) (Message, error) {
 	if msg.NodesCount, err = reader.ReadUint(); err != nil {
 		return nil, err
 	}
-	if msg.DOMDropped, err = reader.ReadBoolean(); err != nil {
-		return nil, err
-	}
 	return msg, err
 }
 

ee/connectors/msgcodec/messages.py

@@ -739,9 +739,8 @@ class MouseThrashing(Message):
 class RemovedNodesCount(Message):
     __id__ = 115
 
-    def __init__(self, nodes_count, dom_dropped):
+    def __init__(self, nodes_count):
         self.nodes_count = nodes_count
-        self.dom_dropped = dom_dropped
 
 
 class IssueEvent(Message):

ee/connectors/msgcodec/msgcodec.py

@@ -654,8 +654,7 @@ class MessageCodec(Codec):
 
         if message_id == 115:
             return RemovedNodesCount(
-                nodes_count=self.read_uint(reader),
-                dom_dropped=self.read_boolean(reader)
+                nodes_count=self.read_uint(reader)
             )
 
         if message_id == 125:

frontend/app/player/web/messages/tracker.gen.ts

@@ -454,7 +454,6 @@ type TrMouseThrashing = [
 type TrRemovedNodesCount = [
   type: 115,
   nodesCount: number,
-  domdropped: boolean,
 ]
 
 

mobs/messages.rb

@@ -470,7 +470,6 @@ end
 
 message 115, 'RemovedNodesCount', :replayer => false do
     uint 'NodesCount'
-    boolean 'DOMDropped'
 end
 
 ## Backend-only

tracker/tracker/src/common/messages.gen.ts

@@ -519,7 +519,6 @@ export type MouseThrashing = [
 export type RemovedNodesCount = [
   /*type:*/ Type.RemovedNodesCount,
   /*nodesCount:*/ number,
-  /*domdropped:*/ boolean,
 ]
 
 

tracker/tracker/src/main/app/messages.gen.ts

@@ -835,12 +835,10 @@ export function MouseThrashing(
 
 export function RemovedNodesCount(
   nodesCount: number,
-  domdropped: boolean,
 ): Messages.RemovedNodesCount {
   return [
     Messages.Type.RemovedNodesCount,
     nodesCount,
-    domdropped,
   ]
 }
 

tracker/tracker/src/main/app/nodes.ts

@@ -26,10 +26,6 @@ export default class Nodes {
     listeners.push([type, listener, useCapture])
   }
 
-  getNodesCount() {
-    return this.nodes.length
-  }
-
   registerNode(node: Node): [/*id:*/ number, /*isNew:*/ boolean] {
     let id: number = (node as any)[this.node_id]
     const isNew = id === undefined

tracker/tracker/src/main/app/observer/observer.ts

@@ -218,7 +218,6 @@ export default abstract class Observer {
 
   private unbindTree(node: Node) {
     let removed = 0
-    const nodesCount = this.app.nodes.getNodesCount()
     const id = this.app.nodes.unregisterNode(node)
     if (id !== undefined && this.recents.get(id) === RecentsType.Removed) {
       // Sending RemoveNode only for parent to maintain
@@ -241,7 +240,7 @@ export default abstract class Observer {
         removed += 1
         this.app.nodes.unregisterNode(walker.currentNode)
       }
-      this.app.send(RemovedNodesCount(removed, removed / nodesCount > 0.5))
+      this.app.send(RemovedNodesCount(removed))
     }
   }
 

tracker/tracker/src/webworker/MessageEncoder.gen.ts

@@ -267,7 +267,7 @@ export default class MessageEncoder extends PrimitiveEncoder {
     break
 
     case Messages.Type.RemovedNodesCount:
-      return  this.uint(msg[1]) && this.boolean(msg[2])
+      return  this.uint(msg[1])
     break
 
     }