diff --git a/backend/pkg/messages/messages.go b/backend/pkg/messages/messages.go index 9ee0e572b..232f116c0 100644 --- a/backend/pkg/messages/messages.go +++ b/backend/pkg/messages/messages.go @@ -2105,15 +2105,13 @@ func (msg *MouseThrashing) TypeID() int { type RemovedNodesCount struct { message NodesCount uint64 - DOMDropped bool } func (msg *RemovedNodesCount) Encode() []byte { - buf := make([]byte, 21) + buf := make([]byte, 11) buf[0] = 115 p := 1 p = WriteUint(msg.NodesCount, buf, p) - p = WriteBoolean(msg.DOMDropped, buf, p) return buf[:p] } diff --git a/backend/pkg/messages/read-message.go b/backend/pkg/messages/read-message.go index bd2176a30..715f81d98 100644 --- a/backend/pkg/messages/read-message.go +++ b/backend/pkg/messages/read-message.go @@ -1275,9 +1275,6 @@ func DecodeRemovedNodesCount(reader BytesReader) (Message, error) { if msg.NodesCount, err = reader.ReadUint(); err != nil { return nil, err } - if msg.DOMDropped, err = reader.ReadBoolean(); err != nil { - return nil, err - } return msg, err } diff --git a/ee/connectors/msgcodec/messages.py b/ee/connectors/msgcodec/messages.py index 2060eff81..75cc5309f 100644 --- a/ee/connectors/msgcodec/messages.py +++ b/ee/connectors/msgcodec/messages.py @@ -739,9 +739,8 @@ class MouseThrashing(Message): class RemovedNodesCount(Message): __id__ = 115 - def __init__(self, nodes_count, dom_dropped): + def __init__(self, nodes_count): self.nodes_count = nodes_count - self.dom_dropped = dom_dropped class IssueEvent(Message): diff --git a/ee/connectors/msgcodec/msgcodec.py b/ee/connectors/msgcodec/msgcodec.py index 984fd153a..75ccca196 100644 --- a/ee/connectors/msgcodec/msgcodec.py +++ b/ee/connectors/msgcodec/msgcodec.py @@ -654,8 +654,7 @@ class MessageCodec(Codec): if message_id == 115: return RemovedNodesCount( - nodes_count=self.read_uint(reader), - dom_dropped=self.read_boolean(reader) + nodes_count=self.read_uint(reader) ) if message_id == 125: diff --git a/frontend/app/player/web/messages/tracker.gen.ts b/frontend/app/player/web/messages/tracker.gen.ts index 55afdd58a..fbfe3c6c2 100644 --- a/frontend/app/player/web/messages/tracker.gen.ts +++ b/frontend/app/player/web/messages/tracker.gen.ts @@ -454,7 +454,6 @@ type TrMouseThrashing = [ type TrRemovedNodesCount = [ type: 115, nodesCount: number, - domdropped: boolean, ] diff --git a/mobs/messages.rb b/mobs/messages.rb index 88ae76f20..018effc30 100644 --- a/mobs/messages.rb +++ b/mobs/messages.rb @@ -470,7 +470,6 @@ end message 115, 'RemovedNodesCount', :replayer => false do uint 'NodesCount' - boolean 'DOMDropped' end ## Backend-only diff --git a/tracker/tracker/src/common/messages.gen.ts b/tracker/tracker/src/common/messages.gen.ts index a4c0e4f2a..2578c00a3 100644 --- a/tracker/tracker/src/common/messages.gen.ts +++ b/tracker/tracker/src/common/messages.gen.ts @@ -519,7 +519,6 @@ export type MouseThrashing = [ export type RemovedNodesCount = [ /*type:*/ Type.RemovedNodesCount, /*nodesCount:*/ number, - /*domdropped:*/ boolean, ] diff --git a/tracker/tracker/src/main/app/messages.gen.ts b/tracker/tracker/src/main/app/messages.gen.ts index 052a1caea..589442c2e 100644 --- a/tracker/tracker/src/main/app/messages.gen.ts +++ b/tracker/tracker/src/main/app/messages.gen.ts @@ -835,12 +835,10 @@ export function MouseThrashing( export function RemovedNodesCount( nodesCount: number, - domdropped: boolean, ): Messages.RemovedNodesCount { return [ Messages.Type.RemovedNodesCount, nodesCount, - domdropped, ] } diff --git a/tracker/tracker/src/main/app/nodes.ts b/tracker/tracker/src/main/app/nodes.ts index b94823cce..387679380 100644 --- a/tracker/tracker/src/main/app/nodes.ts +++ b/tracker/tracker/src/main/app/nodes.ts @@ -26,10 +26,6 @@ export default class Nodes { listeners.push([type, listener, useCapture]) } - getNodesCount() { - return this.nodes.length - } - registerNode(node: Node): [/*id:*/ number, /*isNew:*/ boolean] { let id: number = (node as any)[this.node_id] const isNew = id === undefined diff --git a/tracker/tracker/src/main/app/observer/observer.ts b/tracker/tracker/src/main/app/observer/observer.ts index 5972e9850..fc41c4885 100644 --- a/tracker/tracker/src/main/app/observer/observer.ts +++ b/tracker/tracker/src/main/app/observer/observer.ts @@ -218,7 +218,6 @@ export default abstract class Observer { private unbindTree(node: Node) { let removed = 0 - const nodesCount = this.app.nodes.getNodesCount() const id = this.app.nodes.unregisterNode(node) if (id !== undefined && this.recents.get(id) === RecentsType.Removed) { // Sending RemoveNode only for parent to maintain @@ -241,7 +240,7 @@ export default abstract class Observer { removed += 1 this.app.nodes.unregisterNode(walker.currentNode) } - this.app.send(RemovedNodesCount(removed, removed / nodesCount > 0.5)) + this.app.send(RemovedNodesCount(removed)) } } diff --git a/tracker/tracker/src/webworker/MessageEncoder.gen.ts b/tracker/tracker/src/webworker/MessageEncoder.gen.ts index 370c18d50..97fca51e0 100644 --- a/tracker/tracker/src/webworker/MessageEncoder.gen.ts +++ b/tracker/tracker/src/webworker/MessageEncoder.gen.ts @@ -267,7 +267,7 @@ export default class MessageEncoder extends PrimitiveEncoder { break case Messages.Type.RemovedNodesCount: - return this.uint(msg[1]) && this.boolean(msg[2]) + return this.uint(msg[1]) break }