change(tracker): remove dom drop detection on tracker side

This commit is contained in:
nick-delirium 2023-02-14 11:20:24 +01:00 committed by Delirium
parent 01e4412815
commit 532d9b82f8
11 changed files with 5 additions and 22 deletions

View file

@ -2105,15 +2105,13 @@ func (msg *MouseThrashing) TypeID() int {
type RemovedNodesCount struct { type RemovedNodesCount struct {
message message
NodesCount uint64 NodesCount uint64
DOMDropped bool
} }
func (msg *RemovedNodesCount) Encode() []byte { func (msg *RemovedNodesCount) Encode() []byte {
buf := make([]byte, 21) buf := make([]byte, 11)
buf[0] = 115 buf[0] = 115
p := 1 p := 1
p = WriteUint(msg.NodesCount, buf, p) p = WriteUint(msg.NodesCount, buf, p)
p = WriteBoolean(msg.DOMDropped, buf, p)
return buf[:p] return buf[:p]
} }

View file

@ -1275,9 +1275,6 @@ func DecodeRemovedNodesCount(reader BytesReader) (Message, error) {
if msg.NodesCount, err = reader.ReadUint(); err != nil { if msg.NodesCount, err = reader.ReadUint(); err != nil {
return nil, err return nil, err
} }
if msg.DOMDropped, err = reader.ReadBoolean(); err != nil {
return nil, err
}
return msg, err return msg, err
} }

View file

@ -739,9 +739,8 @@ class MouseThrashing(Message):
class RemovedNodesCount(Message): class RemovedNodesCount(Message):
__id__ = 115 __id__ = 115
def __init__(self, nodes_count, dom_dropped): def __init__(self, nodes_count):
self.nodes_count = nodes_count self.nodes_count = nodes_count
self.dom_dropped = dom_dropped
class IssueEvent(Message): class IssueEvent(Message):

View file

@ -654,8 +654,7 @@ class MessageCodec(Codec):
if message_id == 115: if message_id == 115:
return RemovedNodesCount( return RemovedNodesCount(
nodes_count=self.read_uint(reader), nodes_count=self.read_uint(reader)
dom_dropped=self.read_boolean(reader)
) )
if message_id == 125: if message_id == 125:

View file

@ -454,7 +454,6 @@ type TrMouseThrashing = [
type TrRemovedNodesCount = [ type TrRemovedNodesCount = [
type: 115, type: 115,
nodesCount: number, nodesCount: number,
domdropped: boolean,
] ]

View file

@ -470,7 +470,6 @@ end
message 115, 'RemovedNodesCount', :replayer => false do message 115, 'RemovedNodesCount', :replayer => false do
uint 'NodesCount' uint 'NodesCount'
boolean 'DOMDropped'
end end
## Backend-only ## Backend-only

View file

@ -519,7 +519,6 @@ export type MouseThrashing = [
export type RemovedNodesCount = [ export type RemovedNodesCount = [
/*type:*/ Type.RemovedNodesCount, /*type:*/ Type.RemovedNodesCount,
/*nodesCount:*/ number, /*nodesCount:*/ number,
/*domdropped:*/ boolean,
] ]

View file

@ -835,12 +835,10 @@ export function MouseThrashing(
export function RemovedNodesCount( export function RemovedNodesCount(
nodesCount: number, nodesCount: number,
domdropped: boolean,
): Messages.RemovedNodesCount { ): Messages.RemovedNodesCount {
return [ return [
Messages.Type.RemovedNodesCount, Messages.Type.RemovedNodesCount,
nodesCount, nodesCount,
domdropped,
] ]
} }

View file

@ -26,10 +26,6 @@ export default class Nodes {
listeners.push([type, listener, useCapture]) listeners.push([type, listener, useCapture])
} }
getNodesCount() {
return this.nodes.length
}
registerNode(node: Node): [/*id:*/ number, /*isNew:*/ boolean] { registerNode(node: Node): [/*id:*/ number, /*isNew:*/ boolean] {
let id: number = (node as any)[this.node_id] let id: number = (node as any)[this.node_id]
const isNew = id === undefined const isNew = id === undefined

View file

@ -218,7 +218,6 @@ export default abstract class Observer {
private unbindTree(node: Node) { private unbindTree(node: Node) {
let removed = 0 let removed = 0
const nodesCount = this.app.nodes.getNodesCount()
const id = this.app.nodes.unregisterNode(node) const id = this.app.nodes.unregisterNode(node)
if (id !== undefined && this.recents.get(id) === RecentsType.Removed) { if (id !== undefined && this.recents.get(id) === RecentsType.Removed) {
// Sending RemoveNode only for parent to maintain // Sending RemoveNode only for parent to maintain
@ -241,7 +240,7 @@ export default abstract class Observer {
removed += 1 removed += 1
this.app.nodes.unregisterNode(walker.currentNode) this.app.nodes.unregisterNode(walker.currentNode)
} }
this.app.send(RemovedNodesCount(removed, removed / nodesCount > 0.5)) this.app.send(RemovedNodesCount(removed))
} }
} }

View file

@ -267,7 +267,7 @@ export default class MessageEncoder extends PrimitiveEncoder {
break break
case Messages.Type.RemovedNodesCount: case Messages.Type.RemovedNodesCount:
return this.uint(msg[1]) && this.boolean(msg[2]) return this.uint(msg[1])
break break
} }