jan/openreplay
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tracker): removeNode mutation priority over attributes

Browse source
This commit is contained in:
Alex Kaminskii 2022-07-04 19:48:58 +02:00
parent 573bdc5657
commit d83b28079d
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tracker/tracker/src/main/app/observer/observer.ts
View file

@ -184,7 +184,7 @@ export default abstract class Observer {
const [ id, isNew ]= this.app.nodes.registerNode(node);
if (isNew){
this.recents.set(id, RecentsType.New)
} else if (!this.recents.has(id)) {
} else if (this.recents.get(id) !== RecentsType.New) { // can we do just `else` here?
this.recents.set(id, RecentsType.Removed)
}
}
@ -231,6 +231,8 @@ export default abstract class Observer {
// TODO: Clean the logic (though now it workd fine)
if (!hasTag(node, "HTML") || !this.isTopContext) {
if (parent === null) {
// Sometimes one observation contains attribute mutations for the removimg node, which gets ignored here.
// That shouldn't affect the visual rendering ( should it? )
this.unbindNode(node);
return false;
}