jan/openreplay
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

style(tracker): attachNodeListener arg order

Browse source
This commit is contained in:
Alex Kaminskii 2022-09-13 13:15:57 +02:00
parent 7cac0ceff7
commit d5c2e262e1
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tracker/tracker/src/main/app/nodes.ts
View file

@ -12,7 +12,7 @@ export default class Nodes {
attachNodeCallback(nodeCallback: NodeCallback): void {
this.nodeCallbacks.push(nodeCallback)
}
attachNodeListener(type: string, node: Node, listener: EventListener): void {
attachNodeListener(node: Node, type: string, listener: EventListener): void {
const id = this.getID(node)
if (id === undefined) {
return

4
tracker/tracker/src/main/modules/img.ts
View file

@ -97,8 +97,8 @@ export default function (app: App): void {
if (!hasTag(node, 'IMG')) {
return
}
app.nodes.attachNodeListener('error', node, sendImgAttrs.bind(node))
app.nodes.attachNodeListener('load', node, sendImgAttrs.bind(node))
app.nodes.attachNodeListener(node, 'error', sendImgAttrs.bind(node))
app.nodes.attachNodeListener(node, 'load', sendImgAttrs.bind(node))
sendImgAttrs.call(node)
observer.observe(node, { attributes: true, attributeFilter: ['src', 'srcset'] })
})

2
tracker/tracker/src/main/modules/scroll.ts
View file

@ -56,7 +56,7 @@ export default function (app: App): void {
nodeScroll.set(node, [node.scrollLeft, node.scrollTop])
} else if (isRootNode(node)) {
// scroll is not-composed event (https://javascript.info/shadow-dom-events)
app.nodes.attachNodeListener('scroll', node, (e: Event): void => {
app.nodes.attachNodeListener(node, 'scroll', (e: Event): void => {
setNodeScroll(e.target)
})
}