From d30b663195f03dc58e0226bb24732589a3782e79 Mon Sep 17 00:00:00 2001 From: Alex Kaminskii Date: Fri, 20 May 2022 19:05:32 +0200 Subject: [PATCH] fix(player): use append() instead of add(); update lastMessageTime inside distributeMessage --- backend/Dockerfile | 2 +- frontend/app/player/MessageDistributor/MessageDistributor.ts | 3 +-- .../app/player/MessageDistributor/managers/DOMManager.ts | 5 ++--- .../MessageDistributor/managers/PerformanceTrackManager.ts | 2 +- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/backend/Dockerfile b/backend/Dockerfile index 3815b6c37..20fd55f2c 100644 --- a/backend/Dockerfile +++ b/backend/Dockerfile @@ -30,7 +30,7 @@ ENV TZ=UTC \ BEACON_SIZE_LIMIT=7000000 \ KAFKA_USE_SSL=true \ KAFKA_MAX_POLL_INTERVAL_MS=400000 \ - REDIS_STREAMS_MAX_LEN=3000 \ + REDIS_STREAMS_MAX_LEN=5000 \ TOPIC_RAW_WEB=raw \ TOPIC_RAW_IOS=raw-ios \ TOPIC_CACHE=cache \ diff --git a/frontend/app/player/MessageDistributor/MessageDistributor.ts b/frontend/app/player/MessageDistributor/MessageDistributor.ts index 0de7d5e27..6b04626d4 100644 --- a/frontend/app/player/MessageDistributor/MessageDistributor.ts +++ b/frontend/app/player/MessageDistributor/MessageDistributor.ts @@ -142,8 +142,6 @@ export default class MessageDistributor extends StatedScreen { while (next = r.next()) { const [msg, index] = next this.distributeMessage(msg, index) - this.lastMessageTime = Math.max(msg.time, this.lastMessageTime) - msgs.push(msg) } @@ -296,6 +294,7 @@ export default class MessageDistributor extends StatedScreen { /* Binded */ distributeMessage(msg: Message, index: number): void { + this.lastMessageTime = Math.max(msg.time, this.lastMessageTime) if ([ "mouse_move", "mouse_click", diff --git a/frontend/app/player/MessageDistributor/managers/DOMManager.ts b/frontend/app/player/MessageDistributor/managers/DOMManager.ts index f2c48ab5c..d1cb0ae4e 100644 --- a/frontend/app/player/MessageDistributor/managers/DOMManager.ts +++ b/frontend/app/player/MessageDistributor/managers/DOMManager.ts @@ -34,7 +34,7 @@ export default class DOMManager extends ListWalker { return this.startTime; } - add(m: Message): void { + append(m: Message): void { switch (m.tp) { case "set_node_scroll": if (!this.nodeScrollManagers[ m.id ]) { @@ -155,13 +155,12 @@ export default class DOMManager extends ListWalker { this.insertNode(msg); return case "create_element_node": - // console.log('elementnode', msg) if (msg.svg) { this.nl[ msg.id ] = document.createElementNS('http://www.w3.org/2000/svg', msg.tag); } else { this.nl[ msg.id ] = document.createElement(msg.tag); } - if (this.bodyId === msg.id) { + if (this.bodyId === msg.id) { // there are several bodies in iframes TODO: optimise & cache prebuild this.postponedBodyMessage = msg; } else { this.insertNode(msg); diff --git a/frontend/app/player/MessageDistributor/managers/PerformanceTrackManager.ts b/frontend/app/player/MessageDistributor/managers/PerformanceTrackManager.ts index ceace6581..24aa73375 100644 --- a/frontend/app/player/MessageDistributor/managers/PerformanceTrackManager.ts +++ b/frontend/app/player/MessageDistributor/managers/PerformanceTrackManager.ts @@ -22,7 +22,7 @@ export default class PerformanceTrackManager extends ListWalker