From d15961ace897fc30e8dfcb539190697652ac1515 Mon Sep 17 00:00:00 2001
From: nick-delirium <nikita@openreplay.com>
Date: Mon, 30 Jan 2023 11:44:13 +0100
Subject: [PATCH] fix(ui): small ui bugs (zindex for select, player scale)

---
 .../ClickMapCard/ClickMapCard.tsx                    |  2 +-
 .../FilterValueDropdown.module.css                   |  1 +
 frontend/app/player/web/WebPlayer.ts                 | 12 ++++++++----
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/frontend/app/components/Dashboard/Widgets/CustomMetricsWidgets/ClickMapCard/ClickMapCard.tsx b/frontend/app/components/Dashboard/Widgets/CustomMetricsWidgets/ClickMapCard/ClickMapCard.tsx
index 48ec42156..4c2f2935a 100644
--- a/frontend/app/components/Dashboard/Widgets/CustomMetricsWidgets/ClickMapCard/ClickMapCard.tsx
+++ b/frontend/app/components/Dashboard/Widgets/CustomMetricsWidgets/ClickMapCard/ClickMapCard.tsx
@@ -61,7 +61,7 @@ function ClickMapCard({
         return evt
     }) || { timestamp: metricStore.instance.data.startTs }
 
-    const jumpTimestamp = (jumpToEvent.timestamp - metricStore.instance.data.startTs) + jumpToEvent.domBuildingTime
+    const jumpTimestamp = (jumpToEvent.timestamp - metricStore.instance.data.startTs) + jumpToEvent.domBuildingTime + 99 // 99ms safety margin to give some time for the DOM to load
 
     return (
         <div id="clickmap-render">
diff --git a/frontend/app/components/shared/Filters/FilterValueDropdown/FilterValueDropdown.module.css b/frontend/app/components/shared/Filters/FilterValueDropdown/FilterValueDropdown.module.css
index 010042bf3..b0ca01016 100644
--- a/frontend/app/components/shared/Filters/FilterValueDropdown/FilterValueDropdown.module.css
+++ b/frontend/app/components/shared/Filters/FilterValueDropdown/FilterValueDropdown.module.css
@@ -6,6 +6,7 @@
   align-items: center;
   height: 26px;
   width: 100%;
+  z-index: 3;
 
   & .right {
     height: 24px;
diff --git a/frontend/app/player/web/WebPlayer.ts b/frontend/app/player/web/WebPlayer.ts
index 541e942ca..fb4386676 100644
--- a/frontend/app/player/web/WebPlayer.ts
+++ b/frontend/app/player/web/WebPlayer.ts
@@ -62,12 +62,16 @@ export default class WebPlayer extends Player {
 
   }
 
-  attach = (parent: HTMLElement) => {
+  attach = (parent: HTMLElement, isClickmap?: boolean) => {
     this.screen.attach(parent)
-    window.addEventListener('resize', this.scale)
-    this.scale()
+    if (!isClickmap) {
+      window.addEventListener('resize', this.scale)
+      this.scale()
+    }
   }
+
   scale = () => {
+    console.log('called scale')
     const { width, height } = this.wpState.get()
     this.screen.scale({ width, height })
     this.inspectorController.scale({ width, height })
@@ -76,7 +80,7 @@ export default class WebPlayer extends Player {
   }
 
   scaleFullPage = () => {
-    window.removeEventListener('resize', this.scaleFullPage)
+    window.removeEventListener('resize', this.scale)
     window.addEventListener('resize', this.scaleFullPage)
 
     const portHeight = this.screen.scaleFullPage()