From d031210365bf3d2149fa28549d0e013c2aba30be Mon Sep 17 00:00:00 2001
From: nick-delirium <nikita@openreplay.com>
Date: Thu, 13 Feb 2025 12:33:39 +0100
Subject: [PATCH] ui: conditional rec fixes

---
 .../shared/ConditionSet/ConditionSet.tsx           | 14 +++++++++++++-
 .../shared/Filters/FilterList/FilterList.tsx       | 10 +++++++---
 tracker/tracker/src/main/index.ts                  |  3 ++-
 .../tracker/src/main/modules/conditionsManager.ts  | 12 +++++-------
 4 files changed, 27 insertions(+), 12 deletions(-)

diff --git a/frontend/app/components/shared/ConditionSet/ConditionSet.tsx b/frontend/app/components/shared/ConditionSet/ConditionSet.tsx
index 160dc171a..bb45e452e 100644
--- a/frontend/app/components/shared/ConditionSet/ConditionSet.tsx
+++ b/frontend/app/components/shared/ConditionSet/ConditionSet.tsx
@@ -1,7 +1,7 @@
 import React from 'react';
 import { Icon, Input } from 'UI';
 import cn from 'classnames';
-import { FilterList } from 'Shared/Filters/FilterList';
+import { FilterList, EventsList } from 'Shared/Filters/FilterList';
 import { observer } from 'mobx-react-lite';
 import { Typography } from 'antd';
 import { BranchesOutlined } from '@ant-design/icons';
@@ -77,6 +77,18 @@ function ConditionSetComponent({
       </div>
       <div className={'p-2'}>
         <div className={conditions.filter.filters.length > 0 ? 'p-2 mb-2' : ''}>
+          <EventsList
+            filter={conditions.filter}
+            onUpdateFilter={onUpdateFilter}
+            onRemoveFilter={onRemoveFilter}
+            onChangeEventsOrder={onChangeEventsOrder}
+            hideEventsOrder
+            onAddFilter={onAddFilter}
+            excludeFilterKeys={excludeFilterKeys}
+            readonly={readonly}
+            isConditional={isConditional}
+            borderless
+          />
           <FilterList
             filter={conditions.filter}
             onUpdateFilter={onUpdateFilter}
diff --git a/frontend/app/components/shared/Filters/FilterList/FilterList.tsx b/frontend/app/components/shared/Filters/FilterList/FilterList.tsx
index d28aa1301..f65729781 100644
--- a/frontend/app/components/shared/Filters/FilterList/FilterList.tsx
+++ b/frontend/app/components/shared/Filters/FilterList/FilterList.tsx
@@ -122,7 +122,8 @@ export const EventsList = observer((props: Props) => {
     actions = [],
     onAddFilter,
     cannotAdd,
-    excludeCategory
+    excludeCategory,
+    borderless
   } = props;
 
   const filters = filter.filters;
@@ -199,8 +200,10 @@ export const EventsList = observer((props: Props) => {
   const eventsNum = filters.filter((i: any) => i.isEvent).length;
   return (
     <div
-      className={
-        'border-b border-b-gray-lighter pt-2 px-4 rounded-xl bg-white border border-gray-lighter'
+      className={cn(
+      'bg-white',
+        borderless ? '' : 'pb-2 px-4 rounded-xl border border-gray-lighter'
+      )
       }
       style={{
         borderBottomLeftRadius: props.mergeDown ? 0 : undefined,
@@ -217,6 +220,7 @@ export const EventsList = observer((props: Props) => {
             mode={'events'}
             filter={undefined}
             onFilterClick={onAddFilter}
+            excludeFilterKeys={excludeFilterKeys}
             excludeCategory={excludeCategory}
           >
             <Button
diff --git a/tracker/tracker/src/main/index.ts b/tracker/tracker/src/main/index.ts
index bf599338c..8c5807035 100644
--- a/tracker/tracker/src/main/index.ts
+++ b/tracker/tracker/src/main/index.ts
@@ -201,7 +201,8 @@ export default class API {
     Timing(app, options)
     Focus(app)
     Fonts(app)
-    if (!options.network.disabled) {
+    const skipNetwork = options.network?.disabled
+    if (!skipNetwork) {
       Network(app, options.network)
     }
     Selection(app)
diff --git a/tracker/tracker/src/main/modules/conditionsManager.ts b/tracker/tracker/src/main/modules/conditionsManager.ts
index 8c8076cd7..864fe66c9 100644
--- a/tracker/tracker/src/main/modules/conditionsManager.ts
+++ b/tracker/tracker/src/main/modules/conditionsManager.ts
@@ -87,13 +87,10 @@ export default class ConditionsManager {
   }
 
   createConditionFromFilter = (filter: Filter) => {
-    if (filter.value.length) {
-      const resultCondition = mapCondition(filter)
-      if (resultCondition.type) {
-        return resultCondition
-      }
+    const resultCondition = mapCondition(filter)
+    if (resultCondition.type) {
+      return resultCondition
     }
-    return undefined
   }
 
   trigger(conditionName: string) {
@@ -390,8 +387,9 @@ const mapCondition = (condition: Filter): Condition => {
       con = {
         type: 'session_duration',
         // @ts-ignore
-        value: condition.value[0],
+        value: condition.value,
         key: '',
+        operator: 'is',
       }
       break
     case 'fetchUrl':