jan/openreplay
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(product_analytics): funnels card handle duration

Browse source
This commit is contained in:
Shekar Siri 2025-04-28 10:59:20 +02:00
parent f6485005c6
commit c6076c5e7e
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
backend/pkg/analytics/charts/metric_funnel.go
View file

@ -3,6 +3,7 @@ package charts
import (
"fmt"
"openreplay/backend/pkg/analytics/db"
"strconv"
"strings"
)
@ -49,8 +50,7 @@ func (f FunnelQueryBuilder) buildQuery(p Payload) (string, error) {
metricFormat := p.MetricPayload.MetricFormat
// separate global vs step filters based on IsEvent flag
var globalFilters []Filter
var eventFilters []Filter
var globalFilters, eventFilters []Filter
for _, flt := range s.Filter.Filters {
if flt.IsEvent {
eventFilters = append(eventFilters, flt)
@ -63,9 +63,10 @@ func (f FunnelQueryBuilder) buildQuery(p Payload) (string, error) {
var minDur, maxDur int64
for i := len(globalFilters) - 1; i >= 0; i-- {
if globalFilters[i].Type == "duration" {
if vals, ok := globalFilters[i].Value.([]interface{}); ok && len(vals) == 2 {
minDur = int64(vals[0].(float64))
maxDur = int64(vals[1].(float64))
vals := globalFilters[i].Value // []string
if len(vals) == 2 {
minDur, _ = strconv.ParseInt(vals[0], 10, 64)
maxDur, _ = strconv.ParseInt(vals[1], 10, 64)
}
globalFilters = append(globalFilters[:i], globalFilters[i+1:]...)
}
@ -85,6 +86,7 @@ func (f FunnelQueryBuilder) buildQuery(p Payload) (string, error) {
if maxDur > 0 {
base = append(base, fmt.Sprintf("s.duration BETWEEN %d AND %d", minDur, maxDur))
}
base = append(base, globalConds...)
if len(globalNames) > 0 {
base = append(base, "e.`$event_name` IN ("+buildInClause(globalNames)+")")