From b0d42d26344370a4dcd0aceabe26109c2744b83c Mon Sep 17 00:00:00 2001
From: Taha Yassine Kraiem <tahayk2@gmail.com>
Date: Wed, 23 Mar 2022 18:54:16 +0100
Subject: [PATCH] feat(api): changed funnels drop percentage formula

---
 api/chalicelib/core/funnels.py      |  7 ++++++-
 api/chalicelib/core/significance.py | 26 +-------------------------
 2 files changed, 7 insertions(+), 26 deletions(-)

diff --git a/api/chalicelib/core/funnels.py b/api/chalicelib/core/funnels.py
index 1a56f0272..0b49037e6 100644
--- a/api/chalicelib/core/funnels.py
+++ b/api/chalicelib/core/funnels.py
@@ -217,9 +217,14 @@ def get_top_insights(project_id, user_id, funnel_id, range_value=None, start_dat
         return {"errors": ["funnel not found"]}
     get_start_end_time(filter_d=f["filter"], range_value=range_value, start_date=start_date, end_date=end_date)
     insights, total_drop_due_to_issues = significance.get_top_insights(filter_d=f["filter"], project_id=project_id)
+    insights = helper.list_to_camel_case(insights)
     if len(insights) > 0:
+        # fix: this fix for huge drop count
+        if total_drop_due_to_issues > insights[0]["sessionsCount"]:
+            total_drop_due_to_issues = insights[0]["sessionsCount"]
+        # end fix
         insights[-1]["dropDueToIssues"] = total_drop_due_to_issues
-    return {"data": {"stages": helper.list_to_camel_case(insights),
+    return {"data": {"stages": insights,
                      "totalDropDueToIssues": total_drop_due_to_issues}}
 
 
diff --git a/api/chalicelib/core/significance.py b/api/chalicelib/core/significance.py
index 035890e2f..2e698dcfd 100644
--- a/api/chalicelib/core/significance.py
+++ b/api/chalicelib/core/significance.py
@@ -528,7 +528,7 @@ def get_issues(stages, rows, first_stage=None, last_stage=None, drop_only=False)
         split = issue.split('__^__')
         issues_dict['significant' if is_sign else 'insignificant'].append({
             "type": split[0],
-            "title": get_issue_title(split[0]),
+            "title": helper.get_issue_title(split[0]),
             "affected_sessions": affected_sessions[issue],
             "unaffected_sessions": session_counts[1] - affected_sessions[issue],
             "lost_conversions": lost_conversions,
@@ -641,27 +641,3 @@ def get_overview(filter_d, project_id, first_stage=None, last_stage=None):
     output['stages'] = stages_list
     output['criticalIssuesCount'] = n_critical_issues
     return output
-
-
-def get_issue_title(issue_type):
-    return {'click_rage': "Click Rage",
-            'dead_click': "Dead Click",
-            'excessive_scrolling': "Excessive Scrolling",
-            'bad_request': "Bad Request",
-            'missing_resource': "Missing Image",
-            'memory': "High Memory Usage",
-            'cpu': "High CPU",
-            'slow_resource': "Slow Resource",
-            'slow_page_load': "Slow Page Performance",
-            'crash': "Crash",
-            'ml_cpu': "High CPU",
-            'ml_memory': "High Memory Usage",
-            'ml_dead_click': "Dead Click",
-            'ml_click_rage': "Click Rage",
-            'ml_mouse_thrashing': "Mouse Thrashing",
-            'ml_excessive_scrolling': "Excessive Scrolling",
-            'ml_slow_resources': "Slow Resource",
-            'custom': "Custom Event",
-            'js_exception': "Error",
-            'custom_event_error': "Custom Error",
-            'js_error': "Error"}.get(issue_type, issue_type)