jan/openreplay
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(ui) - custom metrics - fix edit

Browse source
This commit is contained in:
Shekar Siri 2022-02-08 16:37:30 +01:00
parent 7ec1788f6b
commit aae818a5e7
3 changed files with 13 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
frontend/app/components/shared/Filters/FilterValue/FilterValue.tsx
View file

@ -15,17 +15,20 @@ function FilterValue(props: Props) {
const lastIndex = filter.value.length - 1;
const onAddValue = () => {
const newValues = filter.value.concat("")
try {
props.onUpdate({ ...filter.toData(), value: newValues })
} catch (e) {
props.onUpdate({ ...filter, value: newValues })
}
const newValue = filter.value.concat('');
props.onUpdate({ ...filter, value: newValue });
// const newValues = filter.value.concat("")
// try {
// props.onUpdate({ ...filter.toData(), value: newValues })
// } catch (e) {
// props.onUpdate({ ...filter, value: newValues })
// }
}
const onRemoveValue = (valueIndex) => {
const newValues = filter.value.filter((_, _index) => _index !== valueIndex)
props.onUpdate({ ...filter, value: newValues })
const newValue = filter.value.filter((_, index) => index !== valueIndex);
props.onUpdate({ ...filter, value: newValue });
}
const onChange = (e, item, valueIndex) => {
@ -45,13 +48,11 @@ function FilterValue(props: Props) {
}
const handleBlur = (e) => {
// const { filter, onChange } = props;
if (filter.type === FilterType.DURATION) {
const { maxDuration, minDuration, key } = filter;
if (maxDuration || minDuration) return;
if (maxDuration !== durationValues.maxDuration ||
minDuration !== durationValues.minDuration) {
// onChange(e, { name: 'value', value: [this.state.minDuration, this.state.maxDuration] });
props.onUpdate({ ...filter, value: [durationValues.minDuration, durationValues.maxDuration] });
}
}

2
frontend/app/duck/customMetrics.js
View file

@ -44,7 +44,7 @@ const defaultInstance = CustomMetric({
series: List([
{
name: 'Series 1',
filter: new Filter({ filters: [], eventsOrder: 'and' }),
filter: new Filter({ filters: List(), eventsOrder: 'and' }),
},
])
})

2
frontend/app/types/filter/filter.js
View file

@ -95,7 +95,7 @@ export default Record({
startDate,
endDate,
events: List(events).map(Event),
filters: List(filters).map(NewFilter),
filters: List(filters).map(i => NewFilter(i).toData()),
custom: Map(custom),
}
}