From 9f57271af268383566ee0d370c41d3c2fc4f0591 Mon Sep 17 00:00:00 2001 From: nick-delirium Date: Mon, 3 Mar 2025 16:30:24 +0100 Subject: [PATCH] ui: update loglevel for observed node warning, drop digit computing from attributeSender --- tracker/tracker/CHANGELOG.md | 5 +++++ tracker/tracker/package.json | 2 +- tracker/tracker/src/main/app/observer/observer.ts | 2 +- tracker/tracker/src/main/modules/attributeSender.ts | 4 ++-- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/tracker/tracker/CHANGELOG.md b/tracker/tracker/CHANGELOG.md index 06df7f946..7b6b07c26 100644 --- a/tracker/tracker/CHANGELOG.md +++ b/tracker/tracker/CHANGELOG.md @@ -1,3 +1,8 @@ +## 16.0.1 + +- drop computing ts digits +- drop logLevel for "! node is already observed" message (not critical) + ## 16.0.0 - **[breaking]** new string dictionary message format diff --git a/tracker/tracker/package.json b/tracker/tracker/package.json index 1ac42cf54..ba89c0826 100644 --- a/tracker/tracker/package.json +++ b/tracker/tracker/package.json @@ -1,7 +1,7 @@ { "name": "@openreplay/tracker", "description": "The OpenReplay tracker main package", - "version": "16.0.0", + "version": "16.0.1", "keywords": [ "logging", "replay" diff --git a/tracker/tracker/src/main/app/observer/observer.ts b/tracker/tracker/src/main/app/observer/observer.ts index d386b5b81..006c3c7b6 100644 --- a/tracker/tracker/src/main/app/observer/observer.ts +++ b/tracker/tracker/src/main/app/observer/observer.ts @@ -334,7 +334,7 @@ export default abstract class Observer { { acceptNode: (node) => { if (this.app.nodes.getID(node) !== undefined) { - this.app.debug.error('! Node is already bound', node) + this.app.debug.warn('! Node is already bound', node) } return isIgnored(node) || this.app.nodes.getID(node) !== undefined ? NodeFilter.FILTER_REJECT diff --git a/tracker/tracker/src/main/modules/attributeSender.ts b/tracker/tracker/src/main/modules/attributeSender.ts index c5d976d09..200de919b 100644 --- a/tracker/tracker/src/main/modules/attributeSender.ts +++ b/tracker/tracker/src/main/modules/attributeSender.ts @@ -17,8 +17,8 @@ export class StringDictionary { let isNew = false if (!this.backDict[str]) { isNew = true - const digits = Math.floor(Math.log10(Date.now())) + 1 - const shavedTs = Date.now() % (10 ** (digits - 2)) + // shaving the first 2 digits of the timestamp (since they are irrelevant for next millennia) + const shavedTs = Date.now() % 10 ** (13 - 2) let id: number = shavedTs if (id === this.lastTs) { id = id * 10000 + this.lastSuffix