From 95d41c8a3134ae522927de5210525c14e5395ed6 Mon Sep 17 00:00:00 2001 From: Rajesh Rajendran Date: Fri, 17 Jun 2022 11:03:40 +0000 Subject: [PATCH] feat(backend/db): send metadata directly to db (removed from batches) (#544) Co-authored-by: Alexander Zavorotynskiy --- backend/pkg/db/postgres/messages-common.go | 3 +-- backend/services/db/messages.go | 6 +++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/backend/pkg/db/postgres/messages-common.go b/backend/pkg/db/postgres/messages-common.go index 1f4f781ce..223fcade6 100644 --- a/backend/pkg/db/postgres/messages-common.go +++ b/backend/pkg/db/postgres/messages-common.go @@ -155,12 +155,11 @@ func (conn *Conn) InsertUserAnonymousID(sessionID uint64, userAnonymousID string } func (conn *Conn) InsertMetadata(sessionID uint64, keyNo uint, value string) error { - return conn.batchQueue(sessionID, fmt.Sprintf(` + return conn.exec(fmt.Sprintf(` UPDATE sessions SET metadata_%v = $1 WHERE session_id = $2`, keyNo), value, sessionID, ) - // conn.insertAutocompleteValue(sessionID, "METADATA", value) } func (conn *Conn) InsertIssueEvent(sessionID uint64, projectID uint32, e *messages.IssueEvent) error { diff --git a/backend/services/db/messages.go b/backend/services/db/messages.go index d3e4ae1ed..c80432fe8 100644 --- a/backend/services/db/messages.go +++ b/backend/services/db/messages.go @@ -1,6 +1,7 @@ package main import ( + "fmt" . "openreplay/backend/pkg/messages" ) @@ -8,7 +9,10 @@ func insertMessage(sessionID uint64, msg Message) error { switch m := msg.(type) { // Common case *Metadata: - return pg.InsertMetadata(sessionID, m) + if err := pg.InsertMetadata(sessionID, m); err != nil { + return fmt.Errorf("insert metadata err: %s", err) + } + return nil case *IssueEvent: return pg.InsertIssueEvent(sessionID, m) //TODO: message adapter (transformer) (at the level of pkg/message) for types: