From 8fa5bc6f758e04683f809cddabb5cddb4a2b2c11 Mon Sep 17 00:00:00 2001
From: nick-delirium <nikita@openreplay.com>
Date: Fri, 31 Mar 2023 12:36:13 +0200
Subject: [PATCH] fix(player): fix for parser

---
 frontend/app/player/web/MessageManager.ts                    | 2 +-
 frontend/app/player/web/messages/RawMessageReader.gen.ts     | 5 ++---
 ...ntend~app~player~web~messages~RawMessageReader.gen.ts.erb | 5 ++---
 3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/frontend/app/player/web/MessageManager.ts b/frontend/app/player/web/MessageManager.ts
index 5566b5cc6..eee29593e 100644
--- a/frontend/app/player/web/MessageManager.ts
+++ b/frontend/app/player/web/MessageManager.ts
@@ -224,7 +224,7 @@ export default class MessageManager {
         fileReader.append(b)
         const msgs: Array<Message> = []
         for (let msg = fileReader.readNext();msg !== null;msg = fileReader.readNext()) {
-          msg && msgs.push(msg)
+          msgs.push(msg)
         }
         const sorted = msgs.sort((m1, m2) => {
           // @ts-ignore
diff --git a/frontend/app/player/web/messages/RawMessageReader.gen.ts b/frontend/app/player/web/messages/RawMessageReader.gen.ts
index 0ae41e9a4..135960cef 100644
--- a/frontend/app/player/web/messages/RawMessageReader.gen.ts
+++ b/frontend/app/player/web/messages/RawMessageReader.gen.ts
@@ -800,9 +800,8 @@ export default class RawMessageReader extends PrimitiveReader {
     }
 
     default:
-      console.error(`Unrecognizable message type: ${ tp }; Pointer at the position ${this.p} of ${this.buf.length}`)
-      // skipping unrecognized messages
-      return false;
+      throw new Error(`Unrecognizable message type: ${ tp }; Pointer at the position ${this.p} of ${this.buf.length}`)
+      return null;
     }
   }
 }
diff --git a/mobs/templates/frontend~app~player~web~messages~RawMessageReader.gen.ts.erb b/mobs/templates/frontend~app~player~web~messages~RawMessageReader.gen.ts.erb
index 4b59b9d59..3c9268366 100644
--- a/mobs/templates/frontend~app~player~web~messages~RawMessageReader.gen.ts.erb
+++ b/mobs/templates/frontend~app~player~web~messages~RawMessageReader.gen.ts.erb
@@ -30,9 +30,8 @@ export default class RawMessageReader extends PrimitiveReader {
     }
 <% end %>
     default:
-      console.error(`Unrecognizable message type: ${ tp }; Pointer at the position ${this.p} of ${this.buf.length}`)
-      // skipping unrecognized messages
-      return false;
+      throw new Error(`Unrecognizable message type: ${ tp }; Pointer at the position ${this.p} of ${this.buf.length}`)
+      return null;
     }
   }
 }