From 89d45d2247dea087687023abfd136b06f676a7f7 Mon Sep 17 00:00:00 2001
From: Alexander Zavorotynskiy <zavorotynskiy@pm.me>
Date: Tue, 14 Mar 2023 11:53:20 +0100
Subject: [PATCH] feat(backend): added skipped session metric for storage
 service

---
 backend/internal/storage/storage.go    |  2 ++
 backend/pkg/metrics/storage/metrics.go | 26 ++++++++++++++++++++++++++
 2 files changed, 28 insertions(+)

diff --git a/backend/internal/storage/storage.go b/backend/internal/storage/storage.go
index 1e2507163..b1e6b21fb 100644
--- a/backend/internal/storage/storage.go
+++ b/backend/internal/storage/storage.go
@@ -95,6 +95,7 @@ func (s *Storage) Upload(msg *messages.SessionEnd) (err error) {
 	if err != nil {
 		if strings.Contains(err.Error(), "big file") {
 			log.Printf("%s, sess: %d", err, msg.SessionID())
+			metrics.IncreaseStorageTotalSkippedSessions()
 			return nil
 		}
 		return err
@@ -110,6 +111,7 @@ func (s *Storage) openSession(filePath string, tp FileType) ([]byte, error) {
 	// Check file size before download into memory
 	info, err := os.Stat(filePath)
 	if err == nil && info.Size() > s.cfg.MaxFileSize {
+		metrics.RecordSkippedSessionSize(float64(info.Size()), tp.String())
 		return nil, fmt.Errorf("big file, size: %d", info.Size())
 	}
 	// Read file into memory
diff --git a/backend/pkg/metrics/storage/metrics.go b/backend/pkg/metrics/storage/metrics.go
index 26459c90d..2579d7e7c 100644
--- a/backend/pkg/metrics/storage/metrics.go
+++ b/backend/pkg/metrics/storage/metrics.go
@@ -31,6 +31,32 @@ func IncreaseStorageTotalSessions() {
 	storageTotalSessions.Inc()
 }
 
+var storageSkippedSessionSize = prometheus.NewHistogramVec(
+	prometheus.HistogramOpts{
+		Namespace: "storage",
+		Name:      "session_size_bytes",
+		Help:      "A histogram displaying the size of each skipped session file in bytes.",
+		Buckets:   common.DefaultSizeBuckets,
+	},
+	[]string{"file_type"},
+)
+
+func RecordSkippedSessionSize(fileSize float64, fileType string) {
+	storageSkippedSessionSize.WithLabelValues(fileType).Observe(fileSize)
+}
+
+var storageTotalSkippedSessions = prometheus.NewCounter(
+	prometheus.CounterOpts{
+		Namespace: "storage",
+		Name:      "sessions_skipped_total",
+		Help:      "A counter displaying the total number of all skipped sessions because of the size limits.",
+	},
+)
+
+func IncreaseStorageTotalSkippedSessions() {
+	storageTotalSkippedSessions.Inc()
+}
+
 var storageSessionReadDuration = prometheus.NewHistogramVec(
 	prometheus.HistogramOpts{
 		Namespace: "storage",