From 867247dbc0d24c283eba0bab1ddbba99543d580e Mon Sep 17 00:00:00 2001 From: Kraiem Taha Yassine Date: Tue, 23 Jul 2024 13:01:48 +0200 Subject: [PATCH] fix(chalice): fixed insights with filter steps (#2416) --- ee/api/chalicelib/core/sessions_insights.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ee/api/chalicelib/core/sessions_insights.py b/ee/api/chalicelib/core/sessions_insights.py index 5bb433f1c..cb2d90565 100644 --- a/ee/api/chalicelib/core/sessions_insights.py +++ b/ee/api/chalicelib/core/sessions_insights.py @@ -185,8 +185,9 @@ def __filter_subquery(project_id: int, filters: Optional[schemas.SessionsSearchP errors_only=True, favorite_only=None, issue=None, user_id=None) params = {**params, **qp_params} - # TODO: test if this line impacts other cards beside insights - # sub_query = f"INNER JOIN {sub_query} USING(session_id)" + # This line was added because insights is failing when you add filter steps, + # for example when you add a LOCATION filter + sub_query = f"INNER JOIN {sub_query} USING(session_id)" return params, sub_query