From 7422a4919fc78405d161faaffa1bf86b451ad4ef Mon Sep 17 00:00:00 2001 From: nick-delirium Date: Mon, 25 Sep 2023 16:08:47 +0200 Subject: [PATCH] fix(tracker): fix for `{disableStringDict: true}` --- tracker/tracker/CHANGELOG.md | 4 ++++ tracker/tracker/package.json | 2 +- .../tracker/src/main/modules/attributeSender.ts | 17 +++++++++-------- 3 files changed, 14 insertions(+), 9 deletions(-) diff --git a/tracker/tracker/CHANGELOG.md b/tracker/tracker/CHANGELOG.md index b0bc9573a..3f26102af 100644 --- a/tracker/tracker/CHANGELOG.md +++ b/tracker/tracker/CHANGELOG.md @@ -1,3 +1,7 @@ +# 9.0.9 + +- Fix for `{disableStringDict: true}` behavior + # 9.0.8 - added slight delay to iframe handler (rapid updates of stacked frames used to break player) diff --git a/tracker/tracker/package.json b/tracker/tracker/package.json index eb97bf323..ad3590a53 100644 --- a/tracker/tracker/package.json +++ b/tracker/tracker/package.json @@ -1,7 +1,7 @@ { "name": "@openreplay/tracker", "description": "The OpenReplay tracker main package", - "version": "9.0.8", + "version": "9.0.9", "keywords": [ "logging", "replay" diff --git a/tracker/tracker/src/main/modules/attributeSender.ts b/tracker/tracker/src/main/modules/attributeSender.ts index 562dc0600..c7ddb2a59 100644 --- a/tracker/tracker/src/main/modules/attributeSender.ts +++ b/tracker/tracker/src/main/modules/attributeSender.ts @@ -23,15 +23,16 @@ export default class AttributeSender { public sendSetAttribute(id: number, name: string, value: string) { if (this.isDictDisabled) { const msg: SetNodeAttribute = [Type.SetNodeAttribute, id, name, value] - this.app.send(msg) + return this.app.send(msg) + } else { + const message: SetNodeAttributeDict = [ + Type.SetNodeAttributeDict, + id, + this.applyDict(name), + this.applyDict(value), + ] + return this.app.send(message) } - const message: SetNodeAttributeDict = [ - Type.SetNodeAttributeDict, - id, - this.applyDict(name), - this.applyDict(value), - ] - this.app.send(message) } private applyDict(str: string): number {