From 7379b5b9ebdbb6596b50a23a83858ba65dc38392 Mon Sep 17 00:00:00 2001 From: nick-delirium Date: Mon, 13 Mar 2023 09:53:13 +0100 Subject: [PATCH] change(tracker): ignore comment nodes --- tracker/tracker/src/main/app/guards.ts | 4 ++++ tracker/tracker/src/main/app/observer/observer.ts | 12 +++++++++++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/tracker/tracker/src/main/app/guards.ts b/tracker/tracker/src/main/app/guards.ts index c58d03a74..5379f9387 100644 --- a/tracker/tracker/src/main/app/guards.ts +++ b/tracker/tracker/src/main/app/guards.ts @@ -11,6 +11,10 @@ export function isElementNode(node: Node): node is Element { return node.nodeType === Node.ELEMENT_NODE } +export function isCommentNode(node: Node): node is Comment { + return node.nodeType === Node.COMMENT_NODE +} + export function isTextNode(node: Node): node is Text { return node.nodeType === Node.TEXT_NODE } diff --git a/tracker/tracker/src/main/app/observer/observer.ts b/tracker/tracker/src/main/app/observer/observer.ts index c13739622..9e93dde2d 100644 --- a/tracker/tracker/src/main/app/observer/observer.ts +++ b/tracker/tracker/src/main/app/observer/observer.ts @@ -10,9 +10,19 @@ import { RemoveNode, } from '../messages.gen.js' import App from '../index.js' -import { isRootNode, isTextNode, isElementNode, isSVGElement, hasTag } from '../guards.js' +import { + isRootNode, + isTextNode, + isElementNode, + isSVGElement, + hasTag, + isCommentNode, +} from '../guards.js' function isIgnored(node: Node): boolean { + if (isCommentNode(node)) { + return true + } if (isTextNode(node)) { return false }