From 6731d6dc3ba55f07581719e17752afa28bb6a81f Mon Sep 17 00:00:00 2001 From: sylenien Date: Mon, 12 Sep 2022 15:22:05 +0200 Subject: [PATCH] change(tracker): rename ismasked methods --- tracker/tracker/src/main/app/observer/observer.ts | 4 ++-- tracker/tracker/src/main/app/sanitizer.ts | 4 ++-- tracker/tracker/src/main/modules/img.ts | 2 +- tracker/tracker/src/main/modules/input.ts | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tracker/tracker/src/main/app/observer/observer.ts b/tracker/tracker/src/main/app/observer/observer.ts index de489d835..d945f6fe6 100644 --- a/tracker/tracker/src/main/app/observer/observer.ts +++ b/tracker/tracker/src/main/app/observer/observer.ts @@ -259,7 +259,7 @@ export default abstract class Observer { return false } this.app.sanitizer.handleNode(id, parentID, node) - if (this.app.sanitizer.isMaskedContainer(parentID)) { + if (this.app.sanitizer.isHiddenContainer(parentID)) { return false } } @@ -287,7 +287,7 @@ export default abstract class Observer { if (isElementNode(node)) { let el: Element = node if (parentID !== undefined) { - if (this.app.sanitizer.isMaskedContainer(id)) { + if (this.app.sanitizer.isHiddenContainer(id)) { const width = el.clientWidth const height = el.clientHeight el = node.cloneNode() as Element diff --git a/tracker/tracker/src/main/app/sanitizer.ts b/tracker/tracker/src/main/app/sanitizer.ts index 2359fbbb0..9a5aefc69 100644 --- a/tracker/tracker/src/main/app/sanitizer.ts +++ b/tracker/tracker/src/main/app/sanitizer.ts @@ -75,10 +75,10 @@ export default class Sanitizer { return data } - isMasked(id: number): boolean { + isObscured(id: number): boolean { return this.obscured.has(id) } - isMaskedContainer(id: number) { + isHiddenContainer(id: number) { return this.hiddenContainers.has(id) } diff --git a/tracker/tracker/src/main/modules/img.ts b/tracker/tracker/src/main/modules/img.ts index eda09fd1a..f66345fed 100644 --- a/tracker/tracker/src/main/modules/img.ts +++ b/tracker/tracker/src/main/modules/img.ts @@ -63,7 +63,7 @@ export default function (app: App): void { if (isURL(resolvedSrc)) { app.send(ResourceTiming(timestamp(), 0, 0, 0, 0, 0, resolvedSrc, 'img')) } - } else if (resolvedSrc.length >= 1e5 || app.sanitizer.isMasked(id)) { + } else if (resolvedSrc.length >= 1e5 || app.sanitizer.isObscured(id)) { sendPlaceholder(id, this) } else { sendSrc(id, this) diff --git a/tracker/tracker/src/main/modules/input.ts b/tracker/tracker/src/main/modules/input.ts index e8ce1b0da..d34108159 100644 --- a/tracker/tracker/src/main/modules/input.ts +++ b/tracker/tracker/src/main/modules/input.ts @@ -107,7 +107,7 @@ export default function (app: App, opts: Partial): void { if (node.type === 'password' || hasOpenreplayAttribute(node, 'hidden')) { inputMode = InputMode.Hidden } else if ( - app.sanitizer.isMasked(id) || + app.sanitizer.isObscured(id) || (inputMode === InputMode.Plain && ((options.obscureInputNumbers && node.type !== 'date' && /\d\d\d\d/.test(value)) || (options.obscureInputDates && node.type === 'date') ||