From 5e172c636009d54c37177615524d8dda346c4b4b Mon Sep 17 00:00:00 2001 From: Taha Yassine Kraiem Date: Mon, 12 Dec 2022 16:29:09 +0100 Subject: [PATCH] feat(chalice): cards id validation --- api/routers/subs/metrics.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/api/routers/subs/metrics.py b/api/routers/subs/metrics.py index 65404662b..5d4a24bf7 100644 --- a/api/routers/subs/metrics.py +++ b/api/routers/subs/metrics.py @@ -151,6 +151,8 @@ def search_cards(projectId: int, data: schemas.SearchCardsSchema = Body(...), @app.get('/{projectId}/metrics/{metric_id}', tags=["dashboard"]) @app.get('/{projectId}/custom_metrics/{metric_id}', tags=["customMetrics"]) def get_card(projectId: int, metric_id: str, context: schemas.CurrentContext = Depends(OR_context)): + if not isinstance(metric_id,int): + return {"errors": ["invalid card_id"]} data = custom_metrics.get_card(project_id=projectId, user_id=context.user_id, metric_id=metric_id) if data is None: return {"errors": ["card not found"]}