jan/openreplay
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(player): filter messages by type before appending into the DOMManager

Browse source
This commit is contained in:
Alex Kaminskii 2023-01-20 16:27:33 +01:00
parent 983fef55ef
commit 595e9d9b62
4 changed files with 21 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
frontend/app/player/common/ListWalker.ts
View file

@ -6,7 +6,7 @@ export default class ListWalker<T extends Timed> {
append(m: T): void {
if (this.length > 0 && this.last && m.time < this.last.time) {
console.error("Trying to append message with the less time then the list tail:", m.time, 'vs', this.last.time, m)
console.error("Trying to append message with the less time then the list tail:", m.time, 'vs', this.last.time, m, this)
return
}
this.list.push(m);

3
frontend/app/player/web/MessageManager.ts
View file

@ -20,6 +20,7 @@ import ActivityManager from './managers/ActivityManager';
import MFileReader from './messages/MFileReader';
import { MType } from './messages';
import { isDOMType } from './messages/filters.gen';
import type {
Message,
SetPageLocation,
@ -473,7 +474,7 @@ export default class MessageManager {
break;
}
this.performanceTrackManager.addNodeCountPointIfNeed(msg.time)
this.pagesManager.appendMessage(msg);
isDOMType(msg.tp) && this.pagesManager.appendMessage(msg)
break;
}
}

9
frontend/app/player/web/messages/filters.gen.ts Normal file
View file

@ -0,0 +1,9 @@
// Auto-generated, do not edit
/* eslint-disable */
import { MType } from './raw.gen'
const DOM_TYPES = [0,4,5,6,7,8,9,10,11,12,13,14,15,16,18,19,20,37,38,49,54,55,57,58,59,60,61,67,69,70,71,72,73,74,75,76,77,90,93,96,100,102,103,105]
export function isDOMType(t: MType) {
return DOM_TYPES.includes(t)
}

9
mobs/templates/frontend~app~player~web~messages~filters.gen.ts.erb Normal file
View file

@ -0,0 +1,9 @@
// Auto-generated, do not edit
/* eslint-disable */
import { MType } from './raw.gen'
const DOM_TYPES = [<%= $messages.select { |msg| msg.replayer == true }.map { |msg| "#{msg.id}" }.join "," %>]
export function isDOMType(t: MType) {
return DOM_TYPES.includes(t)
}