From 4bf8bf0ffbafd56892233e6704d278dfca6e4bb0 Mon Sep 17 00:00:00 2001
From: nick-delirium <nikita@openreplay.com>
Date: Wed, 2 Oct 2024 15:50:36 +0200
Subject: [PATCH] fixes for bad start, iframes; 14.0.9

---
 tracker/tracker/CHANGELOG.md          |  5 +++++
 tracker/tracker/package.json          |  2 +-
 tracker/tracker/src/main/app/index.ts | 15 ++++++++-------
 3 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/tracker/tracker/CHANGELOG.md b/tracker/tracker/CHANGELOG.md
index 88923305a..3e8e0b398 100644
--- a/tracker/tracker/CHANGELOG.md
+++ b/tracker/tracker/CHANGELOG.md
@@ -1,3 +1,8 @@
+# 14.0.9
+
+- more stable crossdomain iframe tracking (refactored child/parent process discovery)
+- checks for bad start error
+
 # 14.0.8
 
 - use separate library to handle network requests ([@openreplay/network-proxy](https://www.npmjs.com/package/@openreplay/network-proxy))
diff --git a/tracker/tracker/package.json b/tracker/tracker/package.json
index 0b2ea4bee..9cd231668 100644
--- a/tracker/tracker/package.json
+++ b/tracker/tracker/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@openreplay/tracker",
   "description": "The OpenReplay tracker main package",
-  "version": "14.0.9-beta.1",
+  "version": "14.0.9",
   "keywords": [
     "logging",
     "replay"
diff --git a/tracker/tracker/src/main/app/index.ts b/tracker/tracker/src/main/app/index.ts
index 47193440a..ecc3d1f8b 100644
--- a/tracker/tracker/src/main/app/index.ts
+++ b/tracker/tracker/src/main/app/index.ts
@@ -354,6 +354,7 @@ export default class App {
 
     const thisTab = this.session.getTabId()
     const catchParentMessage = (event: MessageEvent) => {
+      if (!this.active()) return
       const { data } = event
       if (!data) return
       if (data.line === proto.parentAlive) {
@@ -370,9 +371,6 @@ export default class App {
     }
 
     window.addEventListener('message', catchParentMessage)
-    this.attachStopCallback(() => {
-      window.removeEventListener('message', catchParentMessage)
-    })
 
     if (this.bc !== null) {
       this.bc.postMessage({
@@ -429,6 +427,7 @@ export default class App {
        * */
       let crossdomainFrameCount = 0
       const catchIframeMessage = (event: MessageEvent) => {
+        if (!this.active()) return;
         const { data } = event
         if (!data) return
         if (data.line === proto.iframeSignal) {
@@ -514,9 +513,6 @@ export default class App {
         }
       }
       window.addEventListener('message', catchIframeMessage)
-      this.attachStopCallback(() => {
-        window.removeEventListener('message', catchIframeMessage)
-      })
     }
   }
 
@@ -711,7 +707,6 @@ export default class App {
       requestIdleCb(() => {
         this.messages.unshift(TabData(this.session.getTabId()))
         this.messages.unshift(Timestamp(this.timestamp()))
-        // why I need to add opt chaining?
         this.worker?.postMessage(this.messages)
         this.commitCallbacks.forEach((cb) => cb(this.messages))
         this.messages.length = 0
@@ -1441,6 +1436,11 @@ export default class App {
     } catch (reason) {
       this.stop()
       this.session.reset()
+      if (!reason) {
+        console.error('Unknown error during start')
+        this.signalError('Unknown error', [])
+        return UnsuccessfulStart('Unknown error')
+      }
       if (reason === CANCELED) {
         this.signalError(CANCELED, [])
         return UnsuccessfulStart(CANCELED)
@@ -1595,6 +1595,7 @@ export default class App {
           this.worker.postMessage('stop')
         }
         this.canvasRecorder?.clear()
+        this.messages.length = 0
       } finally {
         this.activityState = ActivityState.NotActive
       }