jan/openreplay
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

change(tracker): review update

Browse source
This commit is contained in:
sylenien 2022-10-10 15:28:59 +02:00 • committed by Delirium
parent f3b4494097
commit 43b075a759
3 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
frontend/app/player/MessageDistributor/managers/AssistManager.ts
View file

@ -205,7 +205,9 @@ export default class AssistManager {
}
})
socket.on('videofeed', ({ streamId, enabled }) => {
this.videoStreams[streamId].enabled = enabled
if (this.videoStreams[streamId]) {
this.videoStreams[streamId].enabled = enabled
}
})
socket.on('SESSION_DISCONNECTED', e => {
waitingForMessages = true

4
tracker/tracker-assist/src/Assist.ts
View file

@ -249,7 +249,7 @@ export default class Assist {
updateCallerNames()
})
socket.on('videofeed', ({ streamId, enabled, }) => {
callUI?.changeVideoFeed({ streamId, enabled, })
callUI?.toggleVideoStream({ streamId, enabled, })
})
const callingAgents: Map<string, string> = new Map() // !! uses socket.io ID
@ -383,7 +383,7 @@ export default class Assist {
// UI
if (!callUI) {
callUI = new CallWindow(app.debug.error, this.options.callUITemplate)
callUI.setVideoCallback(updateVideoFeed)
callUI.setVideoToggleCallback(updateVideoFeed)
}
callUI.showControls(initiateCallEnd)

7
tracker/tracker-assist/src/CallWindow.ts
View file

@ -146,8 +146,7 @@ export default class CallWindow {
let enabled = false
this.checkRemoteVideoInterval = setInterval(() => {
const settings = this.remoteVideo?.getSettings()
const isDummyVideoTrack =
!!settings && !this.remoteVideo.enabled && (settings.width === 2 || settings.frameRate === 0)
const isDummyVideoTrack = !this.remoteVideo.enabled || (!!settings && (settings.width === 2 || settings.frameRate === 0))
const shouldBeEnabled = !isDummyVideoTrack
if (enabled !== shouldBeEnabled) {
this.toggleRemoteVideoUI((enabled = shouldBeEnabled))
@ -303,7 +302,7 @@ export default class CallWindow {
this.adjustIframeSize()
}
public setVideoCallback(cb) {
public setVideoToggleCallback(cb) {
this.onToggleVideo = cb
}
@ -321,7 +320,7 @@ export default class CallWindow {
this.localStreams = []
}
changeVideoFeed({ streamId, enabled, }: { streamId: string, enabled: boolean}) {
toggleVideoStream({ streamId, enabled, }: { streamId: string, enabled: boolean}) {
if (this.remoteVideo.id === streamId) {
this.remoteVideo.enabled = enabled
}