From c48bc3e19744c56d798e7c0f2b7362aa666b35c9 Mon Sep 17 00:00:00 2001
From: Taha Yassine Kraiem <tahayk2@gmail.com>
Date: Thu, 14 Apr 2022 13:26:56 +0200
Subject: [PATCH 1/2] feat(api): dashboard fixed
 get_domains_errors/get_domains_errors_4xx/get_domains_errors_5xx wrong
 neutral

---
 api/chalicelib/core/dashboard.py | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/api/chalicelib/core/dashboard.py b/api/chalicelib/core/dashboard.py
index 719fabb3a..e5bc8003e 100644
--- a/api/chalicelib/core/dashboard.py
+++ b/api/chalicelib/core/dashboard.py
@@ -1,11 +1,12 @@
+import math
+
 import schemas
 from chalicelib.core import metadata
 from chalicelib.utils import args_transformer
-from chalicelib.utils import helper, dev
+from chalicelib.utils import helper
 from chalicelib.utils import pg_client
 from chalicelib.utils.TimeUTC import TimeUTC
 from chalicelib.utils.metrics_helper import __get_step_size
-import math
 
 
 # Written by David Aznaurov, inspired by numpy.quantile
@@ -75,8 +76,6 @@ METADATA_FIELDS = {"userId": "user_id",
                    "metadata9": "metadata_9",
                    "metadata10": "metadata_10"}
 
-from chalicelib.core import sessions_metas
-
 
 def __get_meta_constraint(project_id, data):
     if len(data.get("filters", [])) == 0:
@@ -127,6 +126,13 @@ SESSIONS_META_FIELDS = {"revId": "rev_id",
                         "browser": "user_browser"}
 
 
+def __get_domains_errors_neutral(rows):
+    neutral = {l: 0 for l in [i for k in [list(v.keys()) for v in rows] for i in k]}
+    if len(neutral.keys()) == 0:
+        neutral = {"All": 0}
+    return neutral
+
+
 def get_processed_sessions(project_id, startTimestamp=TimeUTC.now(delta_days=-1),
                            endTimestamp=TimeUTC.now(),
                            density=7, **args):
@@ -1591,7 +1597,7 @@ def get_crashes(project_id, startTimestamp=TimeUTC.now(delta_days=-1),
 
 def __get_neutral(rows, add_All_if_empty=True):
     neutral = {l: 0 for l in [i for k in [list(v.keys()) for v in rows] for i in k]}
-    if add_All_if_empty and len(neutral.keys()) == 0:
+    if add_All_if_empty and len(neutral.keys()) <= 1:
         neutral = {"All": 0}
     return neutral
 

From b7b1d2b315443e1854403c8fe8f871c4632b5d31 Mon Sep 17 00:00:00 2001
From: Taha Yassine Kraiem <tahayk2@gmail.com>
Date: Thu, 14 Apr 2022 14:00:17 +0200
Subject: [PATCH 2/2] feat(api): dashboard removed unused code

---
 api/chalicelib/core/dashboard.py | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/api/chalicelib/core/dashboard.py b/api/chalicelib/core/dashboard.py
index e5bc8003e..1afa10538 100644
--- a/api/chalicelib/core/dashboard.py
+++ b/api/chalicelib/core/dashboard.py
@@ -126,13 +126,6 @@ SESSIONS_META_FIELDS = {"revId": "rev_id",
                         "browser": "user_browser"}
 
 
-def __get_domains_errors_neutral(rows):
-    neutral = {l: 0 for l in [i for k in [list(v.keys()) for v in rows] for i in k]}
-    if len(neutral.keys()) == 0:
-        neutral = {"All": 0}
-    return neutral
-
-
 def get_processed_sessions(project_id, startTimestamp=TimeUTC.now(delta_days=-1),
                            endTimestamp=TimeUTC.now(),
                            density=7, **args):