From 3bfdd9939b3e392f1d7b650fd177a63822daad1c Mon Sep 17 00:00:00 2001 From: nick-delirium Date: Tue, 9 Jan 2024 13:11:10 +0100 Subject: [PATCH] fix(tracker): add more security to canvas el capture --- tracker/tracker/src/main/app/canvas.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tracker/tracker/src/main/app/canvas.ts b/tracker/tracker/src/main/app/canvas.ts index 0ea6aa49c..c3ed92c6f 100644 --- a/tracker/tracker/src/main/app/canvas.ts +++ b/tracker/tracker/src/main/app/canvas.ts @@ -27,7 +27,12 @@ class CanvasRecorder { startTracking() { this.app.nodes.attachNodeCallback((node: Node): void => { const id = this.app.nodes.getID(node) - if (!id || !hasTag(node, 'canvas') || this.snapshots[id]) { + if (!id) { + return + } + + const isIgnored = this.app.sanitizer.isObscured(id) || this.app.sanitizer.isHidden(id) + if (isIgnored || !hasTag(node, 'canvas') || this.snapshots[id]) { return } const ts = this.app.timestamp()