jan/openreplay
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(ui): fix clickmap crash

Browse source
This commit is contained in:
nick-delirium 2023-03-29 14:24:14 +02:00
parent f471fd3ae1
commit 3a3e1ee688
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frontend/app/player/web/Screen/Screen.ts
View file

@ -83,9 +83,9 @@ export default class Screen {
}
clean() {
this.screen.removeChild(this.iframe)
this.screen.removeChild(this.overlay)
this.screen.remove();
this.iframe?.remove?.();
this.overlay?.remove?.();
this.screen?.remove?.();
}
attach(parentElement: HTMLElement) {

2
frontend/app/player/web/WebPlayer.ts
View file

@ -137,7 +137,7 @@ export default class WebPlayer extends Player {
}
showClickmap = (...args: Parameters<TargetMarker['injectTargets']>) => {
this.screen.overlay.remove() // hack. TODO: 1.split Screen functionalities (overlay, mounter) 2. separate ClickMapPlayer class that does not create overlay
this.screen?.overlay?.remove?.() // hack. TODO: 1.split Screen functionalities (overlay, mounter) 2. separate ClickMapPlayer class that does not create overlay
this.freeze().then(() => {
this.targetMarker.injectTargets(...args)
})