diff --git a/frontend/app/components/Session_/Player/Controls/components/CreateNote.tsx b/frontend/app/components/Session_/Player/Controls/components/CreateNote.tsx index af95e5eea..2fe7075f1 100644 --- a/frontend/app/components/Session_/Player/Controls/components/CreateNote.tsx +++ b/frontend/app/components/Session_/Player/Controls/components/CreateNote.tsx @@ -162,7 +162,7 @@ function CreateNote({

Add Note

setUseTs(!useTimestamp)}> - {`at ${duration}`} + {`at ${duration}`}
diff --git a/frontend/app/components/Session_/Storage/DiffRow.tsx b/frontend/app/components/Session_/Storage/DiffRow.tsx index 4dbd39345..f34be1b40 100644 --- a/frontend/app/components/Session_/Storage/DiffRow.tsx +++ b/frontend/app/components/Session_/Storage/DiffRow.tsx @@ -7,10 +7,25 @@ interface Props { diff: Record; } +const getCircularReplacer = () => { + const seen = new WeakSet(); + // @ts-ignore + return (key, value) => { + if (typeof value === "object" && value !== null) { + if (seen.has(value)) { + return; + } + seen.add(value); + } + return value; + }; +}; + function DiffRow({ diff, path }: Props) { const [shorten, setShorten] = React.useState(true); - const oldValue = diff.item ? JSON.stringify(diff.item.lhs) : JSON.stringify(diff.lhs); - const newValue = diff.item ? JSON.stringify(diff.item.rhs) : JSON.stringify(diff.rhs); + + const oldValue = diff.item ? JSON.stringify(diff.item.lhs, getCircularReplacer()) : JSON.stringify(diff.lhs, getCircularReplacer()); + const newValue = diff.item ? JSON.stringify(diff.item.rhs, getCircularReplacer()) : JSON.stringify(diff.rhs, getCircularReplacer()); const pathStr = path.length > 15 && shorten ? path.slice(0, 5) + '...' + path.slice(10) : path; return ( diff --git a/frontend/app/components/ui/Checkbox/Checkbox.tsx b/frontend/app/components/ui/Checkbox/Checkbox.tsx index ec401557c..e4c91d726 100644 --- a/frontend/app/components/ui/Checkbox/Checkbox.tsx +++ b/frontend/app/components/ui/Checkbox/Checkbox.tsx @@ -10,7 +10,7 @@ export default (props: Props) => { const { className = '', label = '', ...rest } = props; return ( ); diff --git a/frontend/app/components/ui/SVG.tsx b/frontend/app/components/ui/SVG.tsx index 09cf18796..1d3387c8f 100644 --- a/frontend/app/components/ui/SVG.tsx +++ b/frontend/app/components/ui/SVG.tsx @@ -133,7 +133,7 @@ const SVG = (props: Props) => { case 'copy': return ; case 'credit-card-front': return ; case 'cubes': return ; - case 'dashboard-icn': return ; + case 'dashboard-icn': return ; case 'desktop': return ; case 'device': return ; case 'diagram-3': return ; @@ -266,8 +266,8 @@ const SVG = (props: Props) => { case 'integrations/elasticsearch': return ; case 'integrations/github': return ; case 'integrations/graphql': return ; - case 'integrations/jira-text': return ; - case 'integrations/jira': return ; + case 'integrations/jira-text': return ; + case 'integrations/jira': return ; case 'integrations/mobx': return ; case 'integrations/newrelic-text': return ; case 'integrations/newrelic': return ; diff --git a/frontend/app/components/ui/Toggler/Toggler.js b/frontend/app/components/ui/Toggler/Toggler.js index 7aa670743..2fcb31f0d 100644 --- a/frontend/app/components/ui/Toggler/Toggler.js +++ b/frontend/app/components/ui/Toggler/Toggler.js @@ -5,7 +5,7 @@ export default ({ onChange, name, className = '', checked, label = '', plain = f