jan/openreplay
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(ui): fix dead variables (#1939)

Browse source
This commit is contained in:
Delirium 2024-03-11 14:50:49 +01:00 • committed by GitHub
parent 2377cc79d0
commit 34a778527c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
frontend/app/components/shared/SessionSettings/components/CaptureRate.tsx
View file

@ -42,7 +42,7 @@ function CaptureRate(props: Props) {
}, [projectId]);
React.useEffect(() => {
setConditions(captureConditions.map((condition: any) => new Conditions(condition, true, isMobile)));
setConditions(captureConditions.map((condition: any) => new Conditions(condition, true)));
}, [captureConditions]);
const onCaptureRateChange = (input: string) => {

8
frontend/app/mstore/types/filterItem.ts
View file

@ -1,6 +1,6 @@
import { makeAutoObservable, observable, action } from 'mobx';
import { FilterKey, FilterType, FilterCategory } from 'Types/filter/filterType';
import { filtersMap, conditionalFiltersMap, mobileConditionalFiltersMap } from 'Types/filter/newFilter';
import { filtersMap, conditionalFiltersMap } from 'Types/filter/newFilter';
export default class FilterItem {
type: string = '';
@ -65,11 +65,7 @@ export default class FilterItem {
const isMetadata = json.type === FilterKey.METADATA;
let _filter: any = (isMetadata ? filtersMap['_' + json.source] : filtersMap[json.type]) || {};
if (this.isConditional) {
if (this.isMobile) {
_filter = mobileConditionalFiltersMap[json.type] || mobileConditionalFiltersMap[json.source];
} else {
_filter = conditionalFiltersMap[json.type] || conditionalFiltersMap[json.source];
}
_filter = conditionalFiltersMap[json.type] || conditionalFiltersMap[json.source];
}
if (mainFilterKey) {
const mainFilter = filtersMap[mainFilterKey];