diff --git a/frontend/app/components/Dashboard/components/WidgetChart/WidgetChart.tsx b/frontend/app/components/Dashboard/components/WidgetChart/WidgetChart.tsx index e95f47387..c3d40867e 100644 --- a/frontend/app/components/Dashboard/components/WidgetChart/WidgetChart.tsx +++ b/frontend/app/components/Dashboard/components/WidgetChart/WidgetChart.tsx @@ -33,6 +33,7 @@ function WidgetChart(props: Props) { const isTableWidget = metric.metricType === 'table' && metric.viewType === 'table'; const isPieChart = metric.metricType === 'table' && metric.viewType === 'pieChart'; + const isFunnel = metric.metricType === 'funnel'; const onChartClick = (event: any) => { if (event) { @@ -82,7 +83,7 @@ function WidgetChart(props: Props) { const renderChart = () => { const { metricType, viewType } = metric; - if (metricType === 'funnel') { + if (isFunnel) { return } @@ -136,7 +137,7 @@ function WidgetChart(props: Props) { return
Unknown
; } return useObserver(() => ( - + {renderChart()} )); diff --git a/frontend/app/components/Dashboard/components/WidgetForm/WidgetForm.tsx b/frontend/app/components/Dashboard/components/WidgetForm/WidgetForm.tsx index 79b44bc5a..4659a4494 100644 --- a/frontend/app/components/Dashboard/components/WidgetForm/WidgetForm.tsx +++ b/frontend/app/components/Dashboard/components/WidgetForm/WidgetForm.tsx @@ -27,6 +27,7 @@ function WidgetForm(props: Props) { const timeseriesOptions = metricOf.filter(i => i.type === 'timeseries'); const tableOptions = metricOf.filter(i => i.type === 'table'); const isTable = metric.metricType === 'table'; + const isFunnel = metric.metricType === 'funnel'; const _issueOptions = [{ text: 'All', value: 'all' }].concat(issueOptions); const canAddToDashboard = metric.exists() && dashboards.length > 0; const canAddSeries = metric.series.length < 3; @@ -87,7 +88,7 @@ function WidgetForm(props: Props) { } return useObserver(() => ( -
+
@@ -152,8 +153,8 @@ function WidgetForm(props: Props) {
- {`${isTable ? 'Filter by' : 'Chart Series'}`} - {!isTable && ( + {`${(isTable || isFunnel) ? 'Filter by' : 'Chart Series'}`} + {!isTable && !isFunnel && (