diff --git a/frontend/app/components/Dashboard/Widgets/Performance/Performance.js b/frontend/app/components/Dashboard/Widgets/Performance/Performance.js index d31e64269..5dd9879bc 100644 --- a/frontend/app/components/Dashboard/Widgets/Performance/Performance.js +++ b/frontend/app/components/Dashboard/Widgets/Performance/Performance.js @@ -101,7 +101,7 @@ export default class Performance extends React.PureComponent { compare = () => this.setState({ comparing: true }) - legendPopup = (component, trigger) => + legendPopup = (component, trigger) => {trigger} legendFormatter = (value, entry, index) => { const { opacity } = this.state; diff --git a/frontend/app/components/Dashboard/components/WidgetName/WidgetName.tsx b/frontend/app/components/Dashboard/components/WidgetName/WidgetName.tsx index 52beded51..67be4930d 100644 --- a/frontend/app/components/Dashboard/components/WidgetName/WidgetName.tsx +++ b/frontend/app/components/Dashboard/components/WidgetName/WidgetName.tsx @@ -15,13 +15,14 @@ function WidgetName(props: Props) { const [name, setName] = useState(props.name) const ref = useRef(null) - const write = ({ target: { value, name } }) => { + const write = ({ target: { value } }) => { setName(value) } - const onBlur = () => { + const onBlur = (nameInput?: string) => { setEditing(false) - props.onUpdate(name.trim() === '' ? 'New Widget' : name) + const toUpdate = nameInput || name + props.onUpdate(toUpdate.trim() === '' ? 'New Widget' : toUpdate) } useEffect(() => { @@ -37,7 +38,7 @@ function WidgetName(props: Props) { useEffect(() => { const handler = (e: KeyboardEvent) => { if (e.key === 'Enter') { - onBlur() + onBlur(name) } if (e.key === 'Escape' || e.key === 'Esc') { setEditing(false) @@ -48,7 +49,7 @@ function WidgetName(props: Props) { return () => { document.removeEventListener('keydown', handler, false) } - }, []) + }, [name]) return (
@@ -59,7 +60,7 @@ function WidgetName(props: Props) { className="rounded fluid border-0 -mx-2 px-2 h-8" value={name} onChange={write} - onBlur={onBlur} + onBlur={() => onBlur()} onFocus={() => setEditing(true)} /> ) : ( diff --git a/frontend/app/components/Session_/Player/Controls/Timeline.js b/frontend/app/components/Session_/Player/Controls/Timeline.js index 01b6d8351..95742874c 100644 --- a/frontend/app/components/Session_/Player/Controls/Timeline.js +++ b/frontend/app/components/Session_/Player/Controls/Timeline.js @@ -14,6 +14,12 @@ import { Tooltip } from 'react-tippy'; const BOUNDRY = 15 +function getTimelinePosition(value, scale) { + const pos = value * scale; + + return pos > 100 ? 100 : pos; +} + const getPointerIcon = (type) => { // exception, switch(type) { @@ -166,7 +172,7 @@ export default class Timeline extends React.PureComponent { key={ interval.start } className={ stl.skipInterval } style={ { - left: `${ interval.start * scale }%`, + left: `${getTimelinePosition(interval.start, scale)}%`, width: `${ (interval.end - interval.start) * scale }%`, } } />)) @@ -176,7 +182,7 @@ export default class Timeline extends React.PureComponent {
)) } @@ -184,7 +190,7 @@ export default class Timeline extends React.PureComponent { issues.map(iss => (
} > - +
)) @@ -209,7 +215,7 @@ export default class Timeline extends React.PureComponent { { events.filter(e => e.type === TYPES.CLICKRAGE).map(e => (
} setOpen(o => !o) } - className={ cn("bg-teal flex items-center justify-center", cls.addStepButton, {[cls.openMenuBtn] : open }) } - > - - - } content={ `Add Step` } size="tiny" inverted position="top center" - /> + > + + ); }); -