From 31c852df2b88468b368cd033fe7fda195e14c42f Mon Sep 17 00:00:00 2001 From: Alexander Zavorotynskiy Date: Tue, 24 May 2022 13:30:25 +0200 Subject: [PATCH] feat(backend/sink): added error log for consumer.Commit() method --- backend/cmd/sink/main.go | 10 ++++++---- .../openreplay/charts/sink/templates/deployment.yaml | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/backend/cmd/sink/main.go b/backend/cmd/sink/main.go index 913458c39..3c1515aca 100644 --- a/backend/cmd/sink/main.go +++ b/backend/cmd/sink/main.go @@ -78,18 +78,20 @@ func main() { select { case sig := <-sigchan: log.Printf("Caught signal %v: terminating\n", sig) - consumer.Commit() + if err := consumer.Commit(); err != nil { + log.Printf("can't commit messages: %s", err) + } consumer.Close() os.Exit(0) case <-tick: if err := writer.SyncAll(); err != nil { log.Fatalf("Sync error: %v\n", err) } - log.Printf("%v messages during 30 sec", count) count = 0 - - consumer.Commit() + if err := consumer.Commit(); err != nil { + log.Printf("can't commit messages: %s", err) + } default: err := consumer.ConsumeNext() if err != nil { diff --git a/scripts/helmcharts/openreplay/charts/sink/templates/deployment.yaml b/scripts/helmcharts/openreplay/charts/sink/templates/deployment.yaml index 0c3a6ed35..999eb9c74 100644 --- a/scripts/helmcharts/openreplay/charts/sink/templates/deployment.yaml +++ b/scripts/helmcharts/openreplay/charts/sink/templates/deployment.yaml @@ -54,7 +54,7 @@ spec: # 4. Using AWS itself. # AWS uses bucketname.endpoint/object while others use endpoint/bucketname/object - name: ASSETS_ORIGIN - {{ - if eq .Values.global.s3.endpoint "http://minio.db.svc.cluster.local:9000" }} + {{- if eq .Values.global.s3.endpoint "http://minio.db.svc.cluster.local:9000" }} {{- range $key, $val := .Values.env }} - name: {{ $key }} value: '{{ $val }}'