From 308ef872f402fa37e50fac78e7dd7e57e57944b8 Mon Sep 17 00:00:00 2001 From: sylenien Date: Wed, 22 Jun 2022 09:54:26 +0200 Subject: [PATCH] fix(tracker): code review --- tracker/tracker/src/main/app/observer/observer.ts | 4 ---- tracker/tracker/src/main/app/sanitizer.ts | 9 ++++++--- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/tracker/tracker/src/main/app/observer/observer.ts b/tracker/tracker/src/main/app/observer/observer.ts index 79c92cc47..ba6e46895 100644 --- a/tracker/tracker/src/main/app/observer/observer.ts +++ b/tracker/tracker/src/main/app/observer/observer.ts @@ -239,8 +239,6 @@ export default abstract class Observer { return false; } this.app.sanitizer.handleNode(id, parentID, node); - } - if (parentID) { if (this.app.sanitizer.isMaskedContainer(parentID)) { return false; } @@ -270,11 +268,9 @@ export default abstract class Observer { if (this.app.sanitizer.isMaskedContainer(id)) { const width = el.clientWidth; const height = el.clientHeight; - console.log(width, height); el = node.cloneNode() as Element; (el as HTMLElement | SVGElement).style.width = width + 'px'; (el as HTMLElement | SVGElement).style.height = height + 'px'; - console.log(el) } this.app.send(new diff --git a/tracker/tracker/src/main/app/sanitizer.ts b/tracker/tracker/src/main/app/sanitizer.ts index 3b783041a..d870cfaca 100644 --- a/tracker/tracker/src/main/app/sanitizer.ts +++ b/tracker/tracker/src/main/app/sanitizer.ts @@ -23,12 +23,15 @@ export default class Sanitizer { if ( this.masked.has(parentID) || (isElementNode(node) && - (hasOpenreplayAttribute(node, 'masked'))) + hasOpenreplayAttribute(node, 'masked')) ) { this.masked.add(id); } - if (this.maskedContainers.has(parentID) || - (isElementNode(node) && hasOpenreplayAttribute(node, 'htmlmasked'))) { + if ( + this.maskedContainers.has(parentID) || + (isElementNode(node) && + hasOpenreplayAttribute(node, 'htmlmasked')) + ) { this.maskedContainers.add(id); } }