jan/openreplay
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix ui: fix warnings

Browse source
This commit is contained in:
nick-delirium 2024-07-03 11:08:12 +02:00
parent 4dacaf1674
commit 2ffc9459d3
No known key found for this signature in database
GPG key ID: 93ABD695DF5FDBA0
3 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
frontend/app/components/Dashboard/NewDashboard.tsx
View file

@ -1,11 +1,9 @@
import React, { useEffect } from 'react';
import { useObserver } from 'mobx-react-lite';
import { observer } from 'mobx-react-lite';
import { useStore } from 'App/mstore';
import { withRouter, RouteComponentProps } from 'react-router-dom';
import DashboardSideMenu from './components/DashboardSideMenu';
import { Loader } from 'UI';
import DashboardRouter from './components/DashboardRouter';
import cn from 'classnames';
import withPermissions from 'HOCs/withPermissions';
interface RouterProps {
@ -17,7 +15,7 @@ interface RouterProps {
function NewDashboard(props: RouteComponentProps<RouterProps>) {
const { history, match: { params: { siteId, dashboardId } } } = props;
const { dashboardStore } = useStore();
const loading = useObserver(() => dashboardStore.isLoading);
const loading = dashboardStore.isLoading;
const isMetricDetails = history.location.pathname.includes('/metrics/') || history.location.pathname.includes('/metric/');
const isDashboardDetails = history.location.pathname.includes('/dashboard/');
const isAlertsDetails = history.location.pathname.includes('/alert/');
@ -31,11 +29,11 @@ function NewDashboard(props: RouteComponentProps<RouterProps>) {
});
}, [siteId]);
return useObserver(() => (
return (
<Loader loading={loading} className='mt-12'>
<DashboardRouter />
</Loader>
));
);
}
export default withRouter(withPermissions(['METRICS'])(NewDashboard));
export default withRouter(withPermissions(['METRICS'])(observer(NewDashboard)));

2
frontend/app/components/Dashboard/components/MetricListItem/MetricListItem.tsx
View file

@ -25,7 +25,6 @@ function MetricTypeIcon({ type }: any) {
setCard(t);
}, [type]);
console.log(type, TYPES)
return (
<Tooltip title={<div className="capitalize">{card.title}</div>}>
<div className="w-9 h-9 rounded-full bg-tealx-lightest flex items-center justify-center mr-2">
@ -82,7 +81,6 @@ function MetricListItem(props: Props) {
toast.error('Failed to rename card');
}}
console.log(metric)
return (
<>
<Modal open={isEdit} onClose={() => setIsEdit(false)}>

1
frontend/app/components/Dashboard/components/MetricsList/ListView.tsx
View file

@ -38,6 +38,7 @@ function ListView(props: Props) {
</div>
{list.map((metric: any) => (
<MetricListItem
key={metric.metricId}
disableSelection={disableSelection}
metric={metric}
siteId={siteId}