From 2bafb358c50d3f2f9ff1886983c4b202dad418be Mon Sep 17 00:00:00 2001 From: nick-delirium Date: Fri, 13 Oct 2023 12:43:04 +0200 Subject: [PATCH] fix(ui): safe guard for .applyChanges, fixes #1511 --- frontend/app/player/web/managers/DOM/VirtualDOM.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/frontend/app/player/web/managers/DOM/VirtualDOM.ts b/frontend/app/player/web/managers/DOM/VirtualDOM.ts index 4295e31fd..35f2ed994 100644 --- a/frontend/app/player/web/managers/DOM/VirtualDOM.ts +++ b/frontend/app/player/web/managers/DOM/VirtualDOM.ts @@ -1,6 +1,10 @@ import { insertRule, deleteRule } from './safeCSSRules'; import { isRootNode } from 'App/player/guards' +function isNode(sth: any): sth is Node { + return !!sth && sth.nodeType != null +} + type Callback = (o: T) => void /** @@ -100,7 +104,9 @@ abstract class VParent extends VNode{ const realChildren = node.childNodes for(let j = 0; j < this.children.length; j++) { while (realChildren[j] !== this.children[j].node) { - node.removeChild(realChildren[j]) + if (isNode(realChildren[j])) { + node.removeChild(realChildren[j]) + } } } /* Removing tail */