From 2aba1d9a526fcbeec03bf5f268bdb01fca1e1273 Mon Sep 17 00:00:00 2001 From: nick-delirium Date: Wed, 19 Mar 2025 17:29:50 +0100 Subject: [PATCH] ui: comments etc --- .../shared/DevTools/NetworkPanel/NetworkPanel.tsx | 4 +--- .../components/shared/DevTools/NetworkPanel/utils.ts | 12 ++++-------- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/frontend/app/components/shared/DevTools/NetworkPanel/NetworkPanel.tsx b/frontend/app/components/shared/DevTools/NetworkPanel/NetworkPanel.tsx index f433a29d0..32f8f2bcd 100644 --- a/frontend/app/components/shared/DevTools/NetworkPanel/NetworkPanel.tsx +++ b/frontend/app/components/shared/DevTools/NetworkPanel/NetworkPanel.tsx @@ -298,7 +298,6 @@ function MobileNetworkPanelCont({ panelHeight }: { panelHeight: number }) { ); } -// Custom hook for infinite scrolling const useInfiniteScroll = (loadMoreCallback: () => void, hasMore: boolean) => { const observerRef = useRef(null); const loadingRef = useRef(null); @@ -401,7 +400,6 @@ export const NetworkPanelComp = observer( transferredSize: 0, }); - // Store original data in refs to avoid reprocessing const originalListRef = useRef([]); const socketListRef = useRef([]); @@ -799,7 +797,7 @@ export const NetworkPanelComp = observer(
-

Loading network data...

+

Processing initial network data...

) : ( diff --git a/frontend/app/components/shared/DevTools/NetworkPanel/utils.ts b/frontend/app/components/shared/DevTools/NetworkPanel/utils.ts index ee3ac743a..c54130975 100644 --- a/frontend/app/components/shared/DevTools/NetworkPanel/utils.ts +++ b/frontend/app/components/shared/DevTools/NetworkPanel/utils.ts @@ -13,11 +13,7 @@ export function mergeListsWithZoom< return []; } - // Create result array with pre-allocated size estimation - // (We'll set an initial capacity based on rough estimate) - const merged = []; - - // Optimize for common case - no zoom + // Optimized for common case - no zoom if (!zoom?.enabled) { return mergeThreeSortedArrays(arr1, arr2, arr3); } @@ -40,7 +36,6 @@ export function mergeListsWithZoom< ); } -// Helper function to perform binary search to find index of first element >= threshold function binarySearchStartIndex>( arr: T[], threshold: number, @@ -67,13 +62,13 @@ function binarySearchStartIndex>( return low; } -// Specialized function for when no zoom is applied function mergeThreeSortedArrays< T extends Record, Y extends Record, Z extends Record, >(arr1: T[], arr2: Y[], arr3: Z[]): Array { const totalLength = arr1.length + arr2.length + arr3.length; + // prealloc array size const result = new Array(totalLength); let i = 0, @@ -98,7 +93,7 @@ function mergeThreeSortedArrays< return result; } -// Specialized function for merging with zoom range +// same as above, just with zoom stuff function mergeThreeSortedArraysWithinRange< T extends Record, Y extends Record, @@ -113,6 +108,7 @@ function mergeThreeSortedArraysWithinRange< start: number, end: number, ): Array { + // we don't know beforehand how many items will be there const result = []; let i = startIdx1;