jan/openreplay
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tracker): fixed-len BigEndian message size encoding

Browse source
This commit is contained in:
Alex Kaminskii 2022-08-08 18:02:36 +02:00
parent 27806054e0
commit 175be3ef69
1 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
tracker/tracker/src/webworker/BatchWriter.ts
View file

@ -1,16 +1,15 @@
import type Message from '../common/messages.gen.js'
import * as Messages from '../common/messages.gen.js'
import MessageEncoder from './MessageEncoder.gen.js'
import PrimitiveEncoder from './PrimitiveEncoder.js'
const SIZE_BYTES = 2
const SIZE_BYTES = 3
const MAX_M_SIZE = (1 << (SIZE_BYTES * 8)) - 1
export default class BatchWriter {
private nextIndex = 0
private beaconSize = 2 * 1e5 // Default 200kB
private encoder = new MessageEncoder(this.beaconSize)
private readonly sizeEncoder = new PrimitiveEncoder(SIZE_BYTES)
private readonly sizeBuffer = new Uint8Array(SIZE_BYTES)
private isEmpty = true
constructor(
@ -28,6 +27,13 @@ export default class BatchWriter {
private writeFields(m: Message): boolean {
return this.encoder.encode(m)
}
private writeSizeAt(size: number, offset: number): void {
//boolean?
for (let i = 0; i < SIZE_BYTES; i++) {
this.sizeBuffer[i] = size >> (i * 8) // BigEndian
}
this.encoder.set(this.sizeBuffer, offset)
}
private prepare(): void {
if (!this.encoder.isEmpty()) {
@ -59,12 +65,11 @@ export default class BatchWriter {
if (wasWritten) {
const endOffset = e.getCurrentOffset()
const size = endOffset - startOffset
if (size > MAX_M_SIZE || !this.sizeEncoder.uint(size)) {
if (size > MAX_M_SIZE) {
console.warn('OpenReplay: max message size overflow.')
return false
}
this.sizeEncoder.checkpoint() // TODO: separate checkpoint logic to an Encoder-inherit class
e.set(this.sizeEncoder.flush(), startOffset - SIZE_BYTES)
this.writeSizeAt(size, startOffset - SIZE_BYTES)
e.checkpoint()
this.isEmpty = this.isEmpty && message[0] === Messages.Type.Timestamp