jan/openreplay
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(player): fix dict reset (#1214)

Browse source 
Co-authored-by: nick-delirium <nikita@openreplay.com>
This commit is contained in:
Shekar Siri 2023-04-26 15:25:52 +02:00 • committed by GitHub
parent 4589f1ae88
commit 169adb4553
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
frontend/app/player/web/managers/PagesManager.ts
View file

@ -15,7 +15,7 @@ export default class PagesManager extends ListWalker<DOMManager> {
* e.g. some StringDictionary and other messages before any 'CreateDocument' one
* TODO: understand why and fix
*/
private currentStringDict: Record<number, string> = {}
private stringDicts: Record<number, string>[] = [{}]
constructor(
private screen: Screen,
@ -26,17 +26,24 @@ export default class PagesManager extends ListWalker<DOMManager> {
/*
Assumed that messages added in a correct time sequence.
*/
falseOrder = false
appendMessage(m: Message): void {
if (m.tp === MType.StringDict) {
if (this.currentStringDict[m.key] !== undefined) {
this.currentStringDict = {} /* refresh stringDict */
this.last?.setStringDict(this.currentStringDict)
let currentDict = this.stringDicts[0]
if (currentDict[m.key] !== undefined && currentDict[m.key] !== m.value) {
this.falseOrder = true
this.stringDicts.unshift({})
currentDict = this.stringDicts[0]
}
this.currentStringDict[m.key] = m.value
currentDict[m.key] = m.value
return
}
if (m.tp === MType.CreateDocument) {
super.append(new DOMManager(this.screen, this.isMobile, this.currentStringDict, m.time, this.setCssLoading))
if (!this.falseOrder) {
this.stringDicts.unshift({})
}
super.append(new DOMManager(this.screen, this.isMobile, this.stringDicts[0], m.time, this.setCssLoading))
this.falseOrder = false
}
if (this.last === null) {
logger.warn("DOMMessage before any document created, skipping:", m)