Tracker events throttling (#3399)

* add throttling

* fix throttling

* fix throttling
This commit is contained in:
Andrey Babushkin 2025-05-16 14:13:37 +02:00 committed by GitHub
parent 0139e0f1d5
commit 0d3a2015b2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 54 additions and 3 deletions

View file

@ -1,4 +1,4 @@
import { createMutationObserver } from '../../utils.js'
import { createMutationObserver, throttleWithTrailing } from '../../utils.js'
import {
RemoveNodeAttribute,
SetNodeAttributeURLBased,
@ -413,6 +413,11 @@ export default abstract class Observer {
this.app.attributeSender.sendSetAttribute(id, name, value)
}
private throttledSetNodeData = throttleWithTrailing<number, [Element, string]>(
(id, parentElement, data) => this.sendNodeData(id, parentElement, data),
30
);
private sendNodeData(id: number, parentElement: Element, data: string): void {
if (hasTag(parentElement, 'style')) {
this.app.send(SetCSSDataURLBased(id, data, this.app.getBaseHref()))
@ -570,7 +575,7 @@ export default abstract class Observer {
} else if (isTextNode(node)) {
// for text node id != 0, hence parentID !== undefined and parent is Element
this.app.send(CreateTextNode(id, parentID as number, index))
this.sendNodeData(id, parent as Element, node.data)
this.throttledSetNodeData(id, parent as Element, node.data)
}
return true
}
@ -591,7 +596,7 @@ export default abstract class Observer {
throw 'commitNode: node is not a text'
}
// for text node id != 0, hence parent is Element
this.sendNodeData(id, parent as Element, node.data)
this.throttledSetNodeData(id, parent as Element, node.data)
}
return true
}
@ -640,5 +645,6 @@ export default abstract class Observer {
disconnect(): void {
this.observer.disconnect()
this.clear()
this.throttledSetNodeData.clear()
}
}

View file

@ -320,3 +320,48 @@ export function simpleMerge<T>(defaultObj: T, givenObj: Partial<T>): T {
return result
}
export function throttleWithTrailing<K, Args extends any[]>(
fn: (key: K, ...args: Args) => void,
interval: number
): ((key: K, ...args: Args) => void) & { clear: () => void } {
const lastCalls = new Map<K, number>();
const timeouts = new Map<K, ReturnType<typeof setTimeout>>();
const lastArgs = new Map<K, Args>();
const throttled = function (key: K, ...args: Args) {
const now = Date.now();
const lastCall = lastCalls.get(key) ?? 0;
const remaining = interval - (now - lastCall);
lastArgs.set(key, args);
if (remaining <= 0) {
if (timeouts.has(key)) {
clearTimeout(timeouts.get(key)!);
timeouts.delete(key);
}
lastCalls.set(key, now);
fn(key, ...args);
} else if (!timeouts.has(key)) {
const timeoutId = setTimeout(() => {
lastCalls.set(key, Date.now());
timeouts.delete(key);
const finalArgs = lastArgs.get(key)!;
fn(key, ...finalArgs);
}, remaining);
timeouts.set(key, timeoutId);
}
};
throttled.clear = () => {
for (const timeout of timeouts.values()) {
clearTimeout(timeout);
}
timeouts.clear();
lastArgs.clear();
lastCalls.clear();
};
return throttled;
}