jan/openreplay
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #637 from eric-diffagency/storage-override

Browse source 
avoid accessing localStorage and sessionStorage before override
This commit is contained in:
Alex K 2022-08-01 10:32:39 +02:00 • committed by GitHub
commit 0bf3a052be
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
tracker/tracker/src/main/app/index.ts
View file

@ -60,8 +60,8 @@ type AppOptions = {
__is_snippet: boolean;
__debug_report_edp: string | null;
__debug__?: LoggerOptions;
localStorage: Storage;
sessionStorage: Storage;
localStorage: Storage | null;
sessionStorage: Storage | null;
// @deprecated
onStart?: StartCallback;
@ -115,8 +115,8 @@ export default class App {
verbose: false,
__is_snippet: false,
__debug_report_edp: null,
localStorage: window.localStorage,
sessionStorage: window.sessionStorage,
localStorage: null,
sessionStorage: null,
},
options,
);
@ -139,8 +139,10 @@ export default class App {
Object.entries(metadata).forEach(([key, value]) => this.send(new Metadata(key, value)));
}
});
this.localStorage = this.options.localStorage;
this.sessionStorage = this.options.sessionStorage;
// window.localStorage and window.sessionStorage should only be accessed if required, see #490, #637
this.localStorage = this.options.localStorage ?? window.localStorage;
this.sessionStorage = this.options.sessionStorage ?? window.sessionStorage;
if (sessionToken != null) {
this.sessionStorage.setItem(this.options.session_token_key, sessionToken);